From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB48AD65C77 for ; Wed, 17 Dec 2025 16:11:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dWf1T2Nqcz300V; Thu, 18 Dec 2025 03:11:25 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1765987885; cv=none; b=TP2JajUemNhJUiC5O5PdewCKdfVyYd//YDMj3gV8cJ+2gSNlGlSGSE2fb67iF2+wXEVoz+w4lh2w+j0rSXs/yi1M/n6lrvmURNYJB6mMubfZdqlZ4iXRlqiH6dT6Fiv5xj/o6MRVJ2c0pt6G06MqFFqvZIjpROersWiycyD/K/onWD4Ixa+EQGCrOJPPUSBBVbi4pV6VrOSMvCa4PyGa9TdPzRcBbiccCsRpRUbWGRQpsgRJ1+OnRUxRcwXIpduO0qlvzT2KsFz1WurQVTC5v8cnjzOCkQW4UjkQqEIHXOIurkxzX5WrdaAHXOGuOr4UIcJCno3VMZ5gPaiMu1EpPA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1765987885; c=relaxed/relaxed; bh=FNCYahkh/fcmBqFzNzZ6qSdYyO44Ef+U9jbV1jmR+8Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lYsQtxCejFZkB6IdK2pmoJqe85s1vsoHe4QN6cb2Et9ePp+62O3SUUL55B4Av/JBwsUlmsxZMwmbuGonnLRTtq5a5RFQfVLuD/WSQm1SvgqZWU1E5vhJNsueA+VIPldDpun9O9IVZmsujcSGe2G+f5G89zldnxDSZAIgyRTE4wz1VfCob8/T+MvbrQDXwt4XqVjwnPW9JNlVrd7my00jk924I+M7jDGkDEMDrdO6aiW9AK2uCtsCquHijut+BBC+vpprFfSezTUrEqH2aUeIYXJVarHX2Sj9nE5AK/1nXSWKBJY8DMQaBk+qYZmTx59e+P8PVkdC031ZwMBm3B6qgA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=kevin.brodsky@arm.com; receiver=lists.ozlabs.org) smtp.mailfrom=arm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=kevin.brodsky@arm.com; receiver=lists.ozlabs.org) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4dWf1S2PNhz300F for ; Thu, 18 Dec 2025 03:11:23 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 70ACCFEC; Wed, 17 Dec 2025 08:10:45 -0800 (PST) Received: from [10.57.47.3] (unknown [10.57.47.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E837B3F5CA; Wed, 17 Dec 2025 08:10:44 -0800 (PST) Message-ID: <799bdcb5-cb18-4b7a-b33f-bea1553f3650@arm.com> Date: Wed, 17 Dec 2025 17:10:40 +0100 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 14/14] mm: Add basic tests for lazy_mmu To: "Ritesh Harjani (IBM)" , Ryan Roberts , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Anshuman Khandual , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , David Hildenbrand , "David S. Miller" , David Woodhouse , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Suren Baghdasaryan , Thomas Gleixner , Venkat Rao Bagalkote , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org References: <20251215150323.2218608-1-kevin.brodsky@arm.com> <20251215150323.2218608-15-kevin.brodsky@arm.com> <20251216201403.4647a4f9861d3122ee9e90d7@linux-foundation.org> <87a4zhkt6h.ritesh.list@gmail.com> From: Kevin Brodsky Content-Language: en-GB In-Reply-To: <87a4zhkt6h.ritesh.list@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/12/2025 16:46, Ritesh Harjani (IBM) wrote: > Ryan Roberts writes: > >> On 17/12/2025 09:26, Kevin Brodsky wrote: >>> On 17/12/2025 05:14, Andrew Morton wrote: >>>> On Mon, 15 Dec 2025 15:03:23 +0000 Kevin Brodsky wrote: >>>> >>>>> Add basic KUnit tests for the generic aspects of the lazy MMU mode: >>>>> ensure that it appears active when it should, depending on how >>>>> enable/disable and pause/resume pairs are nested. >>>> I needed this for powerpc allmodconfig; >>>> >>>> --- a/arch/powerpc/mm/book3s64/hash_tlb.c~mm-add-basic-tests-for-lazy_mmu-fix >>>> +++ a/arch/powerpc/mm/book3s64/hash_tlb.c >>>> @@ -30,6 +30,7 @@ >>>> #include >>>> >>>> DEFINE_PER_CPU(struct ppc64_tlb_batch, ppc64_tlb_batch); >>>> +EXPORT_SYMBOL_GPL(ppc64_tlb_batch); >>>> >>>> /* >>>> * A linux PTE was changed and the corresponding hash table entry >>>> @@ -154,6 +155,7 @@ void __flush_tlb_pending(struct ppc64_tl >>>> flush_hash_range(i, local); >>>> batch->index = 0; >>>> } >>>> +EXPORT_SYMBOL_GPL(__flush_tlb_pending); >>>> >>>> void hash__tlb_flush(struct mmu_gather *tlb) >>>> { >>>> _ >>> Oh indeed I hadn't considered that arch_{enter,leave}_lazy_mmu_mode() >>> refer to those symbols on powerpc... Maybe a bit overkill to export >>> those just for a test module, but I'm not sure there's a good >>> alternative. Forcing LAZY_MMU_MODE_KUNIT_TEST=y is ugly as it would also >>> force KUNIT=y. Alternatively we could depend on !PPC, not pretty either. >> Does EXPORT_SYMBOL_IF_KUNIT() help? >> > yes, that make sense. Thanks for the suggestion! > I guess we will need a diff like this in that case - > > > diff --git a/arch/powerpc/mm/book3s64/hash_tlb.c b/arch/powerpc/mm/book3s64/hash_tlb.c > index fbdeb8981ae7..ec2941cec815 100644 > --- a/arch/powerpc/mm/book3s64/hash_tlb.c > +++ b/arch/powerpc/mm/book3s64/hash_tlb.c > @@ -25,11 +25,12 @@ > #include > #include > #include > - > +#include > > #include > > DEFINE_PER_CPU(struct ppc64_tlb_batch, ppc64_tlb_batch); > +EXPORT_SYMBOL_IF_KUNIT(ppc64_tlb_batch); > > /* > * A linux PTE was changed and the corresponding hash table entry > @@ -154,6 +155,7 @@ void __flush_tlb_pending(struct ppc64_tlb_batch *batch) > flush_hash_range(i, local); > batch->index = 0; > } > +EXPORT_SYMBOL_IF_KUNIT(__flush_tlb_pending); > > void hash__tlb_flush(struct mmu_gather *tlb) > { > diff --git a/mm/tests/lazy_mmu_mode_kunit.c b/mm/tests/lazy_mmu_mode_kunit.c > index 2720eb995714..340d7cda9096 100644 > --- a/mm/tests/lazy_mmu_mode_kunit.c > +++ b/mm/tests/lazy_mmu_mode_kunit.c > @@ -69,3 +69,4 @@ kunit_test_suite(lazy_mmu_mode_test_suite); > > MODULE_DESCRIPTION("Tests for the lazy MMU mode"); > MODULE_LICENSE("GPL"); > +MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING"); Indeed, that's pretty much what I was about to send :) - Kevin