From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92316C4338F for ; Thu, 5 Aug 2021 08:24:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A906160F43 for ; Thu, 5 Aug 2021 08:24:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A906160F43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GgM8t0HrNz2yL7 for ; Thu, 5 Aug 2021 18:24:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.57; helo=out30-57.freemail.mail.aliyun.com; envelope-from=xianting.tian@linux.alibaba.com; receiver=) Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GgM8Q5LY0z2xtj for ; Thu, 5 Aug 2021 18:24:03 +1000 (AEST) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R531e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04423; MF=xianting.tian@linux.alibaba.com; NM=1; PH=DS; RN=8; SR=0; TI=SMTPD_---0Ui1Bj73_1628151838; Received: from B-LB6YLVDL-0141.local(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0Ui1Bj73_1628151838) by smtp.aliyun-inc.com(127.0.0.1); Thu, 05 Aug 2021 16:23:58 +0800 Subject: Re: [PATCH v3 1/2] tty: hvc: pass DMA capable memory to put_chars() To: Greg KH References: <20210804025453.93543-1-xianting.tian@linux.alibaba.com> <0f26a1c3-53e8-9282-69e8-8d81a9cafc59@kernel.org> <40f78d10-0a57-4620-e7e2-f806bd61abca@linux.alibaba.com> From: Xianting Tian Message-ID: <79af3486-4d65-7d3a-2603-f2a90954311f@linux.alibaba.com> Date: Thu, 5 Aug 2021 16:23:58 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, amit@kernel.org, Jiri Slaby , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, osandov@fb.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" 在 2021/8/5 下午4:18, Greg KH 写道: > On Thu, Aug 05, 2021 at 04:08:46PM +0800, Xianting Tian wrote: >> 在 2021/8/5 下午3:58, Jiri Slaby 写道: >>> Hi, >>> >>> On 04. 08. 21, 4:54, Xianting Tian wrote: >>>> @@ -933,6 +949,16 @@ struct hvc_struct *hvc_alloc(uint32_t vtermno, >>>> int data, >>>>       hp->outbuf_size = outbuf_size; >>>>       hp->outbuf = &((char *)hp)[ALIGN(sizeof(*hp), sizeof(long))]; >>>>   +    /* >>>> +     * hvc_con_outbuf is guaranteed to be aligned at least to the >>>> +     * size(N_OUTBUF) by kmalloc(). >>>> +     */ >>>> +    hp->hvc_con_outbuf = kzalloc(N_OUTBUF, GFP_KERNEL); >>>> +    if (!hp->hvc_con_outbuf) >>>> +        return ERR_PTR(-ENOMEM); >>> This leaks hp, right? >>> >>> BTW your 2 patches are still not threaded, that is hard to follow. >> yes, thanks, I found the bug, I am preparing to do this in v4. >> >> It is the first time I send series patches(number >1), I checked the method >> for sending series patch on LKML.org, I should send '0/2' which is the >> history info for series patches. > Please use 'git send-email' to send the full series all at once, > otherwise it is hard to make the emails threaded "by hand" if you do not > do so. I got it, thanks for your guide:) > > thanks, > > greg k-h