From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jason Jin <Jason.jin@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/4] booting-without-of for Freescale MSI
Date: Mon, 5 May 2008 20:00:22 +0200 [thread overview]
Message-ID: <79f7e810cc79d5912587296c4f44b419@kernel.crashing.org> (raw)
In-Reply-To: <1209973634-1699-4-git-send-email-Jason.jin@freescale.com>
> + - compatible : should be "fsl,MPIC-MSI" for 85xx/86xx cpu,
> + and "fsl,IPIC-MSI" for 83xx cpu.
Please use a more specific name, "fsl,8599-msi" or similar?
> + - interrupts : should contain the msi interrupts cascade to the
> host
> + interrupt controller.
You should describe that it is one "interrupts" entry per 32 MSIs;
also, it would be nice to say they need "0" as the sense.
> + - interrupt-parent: should be "&mpic" for 85xx/86xx cpu and
> "&ipic"
> + for 83xx cpu.
&Xpic are labels, so something local to specific DTS files; instead, say
that the interrupts are routed to the MPIC/IPIC (it doesn't have to be
via "interrupt-parent", either).
Segher
p.s. On a meta-note, please put the binding doc first in the series, it
makes things easier to review in-order.
next prev parent reply other threads:[~2008-05-05 18:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 7:47 [PATCH 1/4 V3] MSI support on 83xx/85xx/86xx board Jason Jin
2008-05-05 7:47 ` [PATCH 2/4 V2] Enable MSI support for MPC8610HPCD board Jason Jin
2008-05-05 7:47 ` [PATCH 3/4] Enable MSI support for 85xxds board Jason Jin
2008-05-05 7:47 ` [PATCH 4/4] booting-without-of for Freescale MSI Jason Jin
2008-05-05 18:00 ` Segher Boessenkool [this message]
2008-05-06 9:23 ` Jin Zhengxiong
2008-05-06 10:44 ` Segher Boessenkool
2008-05-07 9:35 ` Jin Zhengxiong
2008-05-05 11:24 ` [PATCH 1/4 V3] MSI support on 83xx/85xx/86xx board Michael Ellerman
2008-05-06 9:23 ` Jin Zhengxiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79f7e810cc79d5912587296c4f44b419@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=Jason.jin@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).