From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <afleming@freescale.com>
Received: from az33egw02.freescale.net (az33egw02.freescale.net
	[192.88.158.103])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "az33egw02.freescale.net",
	Issuer "Thawte Premium Server CA" (verified OK))
	by ozlabs.org (Postfix) with ESMTP id 19152DDEF0
	for <linuxppc-dev@ozlabs.org>; Tue,  8 May 2007 07:56:27 +1000 (EST)
In-Reply-To: <463F9AC9.8080304@freescale.com>
References: <20070507182957.GK26920@ld0162-tx32.am.freescale.net>
	<20F58AAE-A35D-4BEC-9597-A882567BA5B4@kernel.crashing.org>
	<463F83FC.6080807@freescale.com>
	<1C79B879-58E1-4274-BB90-A6D39FC852C8@freescale.com>
	<463F9AC9.8080304@freescale.com>
Mime-Version: 1.0 (Apple Message framework v752.2)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <7A5205EF-0963-4198-A5DE-4B2FBCEFB206@freescale.com>
From: Andy Fleming <afleming@freescale.com>
Subject: Re: [PATCH 12/13] gianfar: Add flags for magic packet and MDIO.
Date: Mon, 7 May 2007 16:56:24 -0500
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>


On May 7, 2007, at 16:31, Scott Wood wrote:

> Andy Fleming wrote:
>> On May 7, 2007, at 14:54, Scott Wood wrote:
>>> TSEC1 contains the MDIO registers for both TSEC1 and TSEC2.   
>>> Thus,  TSEC1
>>> cannot be put to sleep if TSEC2 is active (plus, the phy timer would
>>> have to be deactivated).  For now, the simple approach of never   
>>> sleeping
>>> TSEC1 is used.
>> The PHY timer is part of the PHY Lib.  The PHY Lib has  
>> infrastructure  to support suspend/resume.  Any thoughts on using  
>> that?  More in an  another email.
>
> If the MDIO registers had their own clock disable bit, then sure.   
> They don't.

Well, I'm getting into that in my gianfar.c review.  Obviously that  
would be ideal, but we code with the hardware we have.  :)

Mostly this was referring to the comment about phy_timer needing to  
be deactivated.

>
> As for the phy timer issue, it seems that phy_stop() doesn't stop  
> the timer, which is probably a bug.


Nope.  phy_timer is used to manage the state_machine of the PHY.   
phy_stop sets the state to HALTED, which means the PHY doesn't  
register any changes.  But it keeps running so that phy_start can  
bring it back online.  If you want to bring down an interface, you  
want phy_disconnect.  That stops the timer.

Andy