Re: [v1 PATCH 1/1] Fix 64bit Maple Host Bridge Address and Size Nodes

[Tiejun Chen <tiejun.china@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Segher,

Thank you very much for your review.

I already re-send this patch as you expect and please check this:
[v2 PATCH 1/1] Fix 64bit Maple Host Bridge 'reg' property

Best Regards
Tiejun

2009/4/14 Segher Boessenkool <segher@kernel.crashing.org>

> In the DTB tree created by firmware on some Maple 64bit targets, such as
>> ATCA6101,
>> these two properties, address&size, should be 2.
>>
>
> And they are.
>
>  But the actual corresponding values
>> of host bridge node are set 1 incorrectly by the firmware, we have to
>> provide one
>> fixup function to fix that.
>>
>
> It is the "reg" property that is incorrectly encoded as-if
> #address-cells and #size-cells were 1.
>
> Please fix the commit message (and subject line).
>
>  +       name = "/hostbridge@f8000000";
>> +       hb = call_prom("finddevice", 1, 1, ADDR(name));
>>
>
> It's interesting that the firmware can find your node this way,
> it won't match the "reg"!  Looks like there is more than one
> bug in there.
>
> Code looks good,
>
> Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
>
>
> Segher
>
>

[-- Attachment #2: Type: text/html, Size: 2117 bytes --]