From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D4DC43613 for ; Mon, 24 Jun 2019 05:38:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ACE32089F for ; Mon, 24 Jun 2019 05:38:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ACE32089F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45XJ4R3BfWzDqVs for ; Mon, 24 Jun 2019 15:38:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=hegdevasant@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45XJ2P6NNxzDqSw for ; Mon, 24 Jun 2019 15:37:01 +1000 (AEST) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5O5aVgW116172 for ; Mon, 24 Jun 2019 01:36:58 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2taqng9hwa-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 24 Jun 2019 01:36:57 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Jun 2019 06:36:56 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 24 Jun 2019 06:36:54 +0100 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5O5arU855050298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Jun 2019 05:36:53 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 20464A405B; Mon, 24 Jun 2019 05:36:53 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1558EA4054; Mon, 24 Jun 2019 05:36:52 +0000 (GMT) Received: from [9.109.241.95] (unknown [9.109.241.95]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 24 Jun 2019 05:36:51 +0000 (GMT) Subject: Re: [PATCH v2 1/2] powerpc/powernv: Enhance opal message read interface To: linuxppc-dev@lists.ozlabs.org References: <20190605114650.19163-1-hegdevasant@linux.vnet.ibm.com> From: Vasant Hegde Date: Mon, 24 Jun 2019 11:06:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20190605114650.19163-1-hegdevasant@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19062405-0020-0000-0000-0000034CC454 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19062405-0021-0000-0000-000021A02AF7 Message-Id: <7a80b69e-20e8-1af2-5eca-4e3a07d12025@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-24_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906240047 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jk@ozlabs.org, Mahesh Salgaonkar Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 06/05/2019 05:16 PM, Vasant Hegde wrote: > Use "opal-msg-size" device tree property to allocate memory for "opal_msg". > Michael, Can you please look into this patchset? Thanks -Vasant > Cc: Mahesh Salgaonkar > Cc: Jeremy Kerr > Signed-off-by: Vasant Hegde > --- > arch/powerpc/platforms/powernv/opal.c | 30 ++++++++++++++++++++---------- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c > index 98c5d94b17fb..e6ea32f3b3c8 100644 > --- a/arch/powerpc/platforms/powernv/opal.c > +++ b/arch/powerpc/platforms/powernv/opal.c > @@ -58,6 +58,8 @@ static DEFINE_SPINLOCK(opal_write_lock); > static struct atomic_notifier_head opal_msg_notifier_head[OPAL_MSG_TYPE_MAX]; > static uint32_t opal_heartbeat; > static struct task_struct *kopald_tsk; > +static struct opal_msg *opal_msg; > +static uint64_t opal_msg_size; > > void opal_configure_cores(void) > { > @@ -264,14 +266,9 @@ static void opal_message_do_notify(uint32_t msg_type, void *msg) > static void opal_handle_message(void) > { > s64 ret; > - /* > - * TODO: pre-allocate a message buffer depending on opal-msg-size > - * value in /proc/device-tree. > - */ > - static struct opal_msg msg; > u32 type; > > - ret = opal_get_msg(__pa(&msg), sizeof(msg)); > + ret = opal_get_msg(__pa(opal_msg), opal_msg_size); > /* No opal message pending. */ > if (ret == OPAL_RESOURCE) > return; > @@ -283,14 +280,14 @@ static void opal_handle_message(void) > return; > } > > - type = be32_to_cpu(msg.msg_type); > + type = be32_to_cpu(opal_msg->msg_type); > > /* Sanity check */ > if (type >= OPAL_MSG_TYPE_MAX) { > pr_warn_once("%s: Unknown message type: %u\n", __func__, type); > return; > } > - opal_message_do_notify(type, (void *)&msg); > + opal_message_do_notify(type, (void *)opal_msg); > } > > static irqreturn_t opal_message_notify(int irq, void *data) > @@ -299,9 +296,22 @@ static irqreturn_t opal_message_notify(int irq, void *data) > return IRQ_HANDLED; > } > > -static int __init opal_message_init(void) > +static int __init opal_message_init(struct device_node *opal_node) > { > int ret, i, irq; > + const __be32 *val; > + > + val = of_get_property(opal_node, "opal-msg-size", NULL); > + if (val) > + opal_msg_size = be32_to_cpup(val); > + > + /* If opal-msg-size property is not available then use default size */ > + if (!opal_msg_size) > + opal_msg_size = sizeof(struct opal_msg); > + > + opal_msg = kmalloc(opal_msg_size, GFP_KERNEL); > + if (!opal_msg) > + return -ENOMEM; > > for (i = 0; i < OPAL_MSG_TYPE_MAX; i++) > ATOMIC_INIT_NOTIFIER_HEAD(&opal_msg_notifier_head[i]); > @@ -903,7 +913,7 @@ static int __init opal_init(void) > } > > /* Initialise OPAL messaging system */ > - opal_message_init(); > + opal_message_init(opal_node); > > /* Initialise OPAL asynchronous completion interface */ > opal_async_comp_init(); >