From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3z2KL83pW4zF0BB for ; Thu, 21 Dec 2017 16:04:00 +1100 (AEDT) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vBL53s44072111 for ; Thu, 21 Dec 2017 00:03:57 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2f05u295an-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 21 Dec 2017 00:03:56 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 21 Dec 2017 05:03:40 -0000 Subject: Re: [PATCH] powerpc/powernv : Add support to enable sensor groups To: Stewart Smith , Michael Ellerman , linuxppc-dev@lists.ozlabs.org References: <1511760988-10377-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <87bmjmzla7.fsf@concordia.ellerman.id.au> <06a771ec-fc79-0515-9166-f2a105eb33d0@linux.vnet.ibm.com> <87609nxfym.fsf@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com, akshay.adiga@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com, "linux@roeck-us.net >> Guenter Roeck" From: Shilpasri G Bhat Date: Thu, 21 Dec 2017 10:33:33 +0530 MIME-Version: 1.0 In-Reply-To: <87609nxfym.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Message-Id: <7b64ac19-5463-5f30-83bb-d5ff0611dc94@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, On 12/04/2017 10:11 AM, Stewart Smith wrote: > Shilpasri G Bhat writes: >> On 11/28/2017 05:07 PM, Michael Ellerman wrote: >>> Shilpasri G Bhat writes: >>> >>>> Adds support to enable/disable a sensor group. This can be used to >>>> select the sensor groups that needs to be copied to main memory by >>>> OCC. Sensor groups like power, temperature, current, voltage, >>>> frequency, utilization can be enabled/disabled at runtime. >>>> >>>> Signed-off-by: Shilpasri G Bhat >>>> --- >>>> The skiboot patch for the opal call is posted below: >>>> https://lists.ozlabs.org/pipermail/skiboot/2017-November/009713.html >>> >>> Can you remind me why we're doing this with a completely bespoke sysfs >>> API, rather than using some generic sensors API? >>> >> >> Disabling/Enabling sensor groups is not supported in the current generic sensors >> API. And also we dont export all type of sensors in HWMON as not all of them are >> environment sensors (like performance). > > Are there barriers to adding such concepts to the generic sensors API? > Yes. HWMON does not support attributes for a sensor-group. If we are to extend HWMON to add new per-sensor attributes to disable/enable, then we need to do either of the below: 1) If any one of the sensor is disabled then all the sensors belonging to that group will be disabled. OR 2) To disable a sensor group we need to disable all the sensors belonging to that group. Another problem is hwmon categorizes the sensor-groups based on the type of sensors like power, temp. If OCC allows multiple groups of the same type then this approach adds some more complexity to the user to identify the sensors belonging to correct group. And lastly HWMON does not allow platform specific non-standard sensor groups like CSM, job-scheduler, profiler. Thanks and Regards, Shilpa