From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71986C35673 for ; Mon, 24 Feb 2020 02:17:31 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C67FF2067D for ; Mon, 24 Feb 2020 02:17:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=neuling.org header.i=@neuling.org header.b="dmEZRWbe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C67FF2067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=neuling.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48Qm143NFTzDqDZ for ; Mon, 24 Feb 2020 13:17:28 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48QlyH4LwbzDqDZ for ; Mon, 24 Feb 2020 13:15:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=neuling.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=neuling.org header.i=@neuling.org header.a=rsa-sha256 header.s=201811 header.b=dmEZRWbe; dkim-atps=neutral Received: from neuling.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 48QlyG0dVfz9sNg; Mon, 24 Feb 2020 13:15:02 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=neuling.org; s=201811; t=1582510502; bh=T10jB91g27CIda1DuAyao920kpjeZyWKNketNp+UJeI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=dmEZRWbeumV2C1GARdwbs2sht9CYu40Ktuuh3vhIbZyTTCvxo0lOOZmlzHljCwKeM 87EK1xzoF8Y/Be60JflnKkvZk+KlbTEiQsx18N9/FWiibbbqUeO6L3PfXqNkHiBlEK XK+Hn8hFqEbbX0WOSL7v+tMPRG9NySbT0AUCdek2Bpiof/dx1ShSnUa0T7nXgJ4Fn7 yRlfNhMXtJRiSuFVz8OmG0tbliSktD6TtSxH4MiFN8YdRKv1SUgChZVlqhwBpkPVQp jbCAGolpm4PhDI6rlKeFhd+3+Sfv3KVIohaig28oEVnBs6yxGYxJx3eM8RPoXwlNXQ 3iEqX4BR21ySA== Received: by neuling.org (Postfix, from userid 1000) id 0C9B12C026F; Mon, 24 Feb 2020 13:15:02 +1100 (AEDT) Message-ID: <7b86733f81c7e15d81ab14b98c8998011ed54880.camel@neuling.org> Subject: Re: [RFC PATCH v2 00/12] Reduce ifdef mess in ptrace From: Michael Neuling To: Christophe Leroy Date: Mon, 24 Feb 2020 13:15:01 +1100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Christophe, > Le 28/06/2019 =C3=A0 17:47, Christophe Leroy a =C3=A9crit : > > The purpose of this series is to reduce the amount of #ifdefs > > in ptrace.c > >=20 >=20 > Any feedback on this series which aims at fixing the issue you opened at= =20 > https://github.com/linuxppc/issues/issues/128 ? Yeah, sorry my bad. You did all the hard work and I ignored it. I like the approach and is a long the lines I was thinking. Putting it in a ptrace subdir, splitting out adv_debug_regs, TM, SPE, Alitivec, VSX. ppc_gethwdinfo() looks a lot nicer now too (that was some of the worst of i= t). I've not gone through it with a fine tooth comb though. There is (rightly) = a lot of code moved around which could have introduced some issues. It applies on v5.2 but are you planning on updating it to a newer base? Mikey