From: Segher Boessenkool <segher@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org, Li Yang <leoli@freescale.com>,
Paul <paulus@samba.org>
Subject: Re: [PATCH v3] 83xx USB platform code rework
Date: Sat, 12 May 2007 16:07:38 +0200 [thread overview]
Message-ID: <7ba6dfe847f334f36560b84e291f2317@kernel.crashing.org> (raw)
In-Reply-To: <20070511221304.a5a14f4e.sfr@canb.auug.org.au>
>> + } else if (prop && !strcmp(prop, "serial")) {
>> + if (!strcmp(of_get_property(np, "dr_mode", NULL), "otg")) {
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Is there any chance that np doesn't have a "dr_mode" property?
Yes, of course -- you can never trust the incoming
device tree to be "correct".
Also, please no underscores in property names.
Segher
prev parent reply other threads:[~2007-05-12 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 11:32 [PATCH v3] 83xx USB platform code rework Li Yang
2007-05-11 12:13 ` Stephen Rothwell
2007-05-12 14:07 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba6dfe847f334f36560b84e291f2317@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).