From: Sean Anderson <sean.anderson@seco.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Roy Pledge <roy.pledge@nxp.com>,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
Scott Wood <oss@buserror.net>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Camelia Groza <camelia.groza@nxp.com>,
linuxppc-dev@lists.ozlabs.org,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock
Date: Mon, 3 Apr 2023 11:22:12 -0400 [thread overview]
Message-ID: <7bd6967a-7f0b-575f-d972-3bf98fab5a6a@seco.com> (raw)
In-Reply-To: <20230403140247.ugb23hqrha2kjup2@skbuf>
On 4/3/23 10:02, Vladimir Oltean wrote:
> On Fri, Mar 31, 2023 at 11:14:12AM -0400, Sean Anderson wrote:
>> smp_call_function_single disables IRQs when executing the callback. To
>> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere.
>> This is already done by qman_update_cgr and qman_delete_cgr; fix the
>> other lockers.
>>
>> Fixes: c535e923bb97 ("soc/fsl: Introduce DPAA 1.x QMan device driver")
>
> If you've identified smp_call_function_single() as the problem, then the
> true issue seems to lie in commit 96f413f47677 ("soc/fsl/qbman: fix
> issue in qman_delete_cgr_safe()") and not in the initial commit, no?
Yes, that seems better. I did a blame and saw that qman_delete_cgr_safe
had been around since the initial driver, but I didn't realize it worked
in a different way back then.
--Sean
> Anyway,
>
> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
next prev parent reply other threads:[~2023-04-03 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 15:14 [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock Sean Anderson
2023-03-31 15:14 ` [PATCH v2 2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock Sean Anderson
2023-04-03 14:06 ` Vladimir Oltean
2023-04-04 9:36 ` Camelia Alexandra Groza
2023-04-03 14:02 ` [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock Vladimir Oltean
2023-04-03 15:22 ` Sean Anderson [this message]
2023-04-04 9:32 ` Camelia Alexandra Groza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bd6967a-7f0b-575f-d972-3bf98fab5a6a@seco.com \
--to=sean.anderson@seco.com \
--cc=camelia.groza@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=roy.pledge@nxp.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox