linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Milton Miller <miltonm@bga.com>
To: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Cc: ppcdev <linuxppc-dev@ozlabs.org>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/2] fix showing xmon help
Date: Wed, 18 Jul 2007 10:51:50 -0500	[thread overview]
Message-ID: <7bd7b12c7bd2303039a850a1fee9634c@bga.com> (raw)
In-Reply-To: <20070718.182640.-1300542340.kouish@swc.toshiba.co.jp>

On Wed Jul 18 19:26:40 EST 2007, Ishizaki Kou wrote:
> In some configuration, xmon help string is larger than xmon_printf
> buffer. We need not to use printf.  This patch adds xmon_puts and
> change to use it to show help string.

[Since I'm requesting changes I'll suggest a new change log.]

In some configurations the xmon help string is larger than the 
xmon_printf buffer.  However, since its a fixed string we do not need 
printf to format it.  This patch adds xmon_puts and uses it to show the 
help string.


>                 case '?':
> -                       printf(help_string);
> +                       xmon_puts(help_string);
>                         break;
>

nonstdio.h #defines printf to xmon_printf.  Please add a similar line 
for puts, and use the define here.  (It will avoid an unnecessary 
difference with the user space version).

Thanks,
milton

  reply	other threads:[~2007-07-18 15:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-18  9:26 [PATCH 2/2] fix showing xmon help Ishizaki Kou
2007-07-18 15:51 ` Milton Miller [this message]
2007-07-18 16:12   ` Andreas Schwab
2007-07-19  5:50     ` Milton Miller
2007-07-20  8:15       ` Ishizaki Kou
2007-07-23  6:49         ` Milton Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bd7b12c7bd2303039a850a1fee9634c@bga.com \
    --to=miltonm@bga.com \
    --cc=kou.ishizaki@toshiba.co.jp \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).