From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: cgel.zte@gmail.com, mpe@ellerman.id.au
Cc: Lv Ruyi <lv.ruyi@zte.com.cn>,
linux-kernel@vger.kernel.org, npiggin@gmail.com,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] module: remove duplicate include in interrupt.c
Date: Mon, 16 Aug 2021 13:57:30 +0200 [thread overview]
Message-ID: <7bf73aea-5758-63e1-ac69-156a2ffecf2c@csgroup.eu> (raw)
In-Reply-To: <20210816113453.126939-1-lv.ruyi@zte.com.cn>
Le 16/08/2021 à 13:34, cgel.zte@gmail.com a écrit :
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> 'asm/interrupt.h' included in 'interrupt.c' is duplicated.
This patch has been submitted at least half a dozen of times already.
You should maintain alphabetic order in the include list.
But please don't post it again, we have it in the pipe already, see
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/1624329437-84730-1-git-send-email-jiapeng.chong@linux.alibaba.com/
Next time please check at https://patchwork.ozlabs.org/project/linuxppc-dev/list/ before submitting
a new patch.
Thanks
Christophe
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> arch/powerpc/kernel/interrupt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
> index 21bbd615ca41..8a936515e4e4 100644
> --- a/arch/powerpc/kernel/interrupt.c
> +++ b/arch/powerpc/kernel/interrupt.c
> @@ -10,7 +10,6 @@
> #include <asm/cputime.h>
> #include <asm/interrupt.h>
> #include <asm/hw_irq.h>
> -#include <asm/interrupt.h>
> #include <asm/kprobes.h>
> #include <asm/paca.h>
> #include <asm/ptrace.h>
>
prev parent reply other threads:[~2021-08-16 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 11:34 [PATCH linux-next] module: remove duplicate include in interrupt.c cgel.zte
2021-08-16 11:57 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bf73aea-5758-63e1-ac69-156a2ffecf2c@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=cgel.zte@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lv.ruyi@zte.com.cn \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox