linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* RE: [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to thestock linux-2.5 (updated)
@ 2005-04-21 16:32 Rune Torgersen
  2005-04-21 17:32 ` Vitaly Bordug
  0 siblings, 1 reply; 8+ messages in thread
From: Rune Torgersen @ 2005-04-21 16:32 UTC (permalink / raw)
  To: Vitaly Bordug; +Cc: Tom Rini, linuxppc-embedded list

	From: Vitaly Bordug [mailto:vbordug@ru.mvista.com]=20
	Sent: Thursday, April 21, 2005 10:29

>	This is all right. The only thing I still don't understand -=20
>how this stuff work without PCI IRQ (don't know much about 8266
though).=20
>On my 8272 only one IRQ is produced and it should be demux'ed in order=20
>for PCI devices to work. I agree that the siumcr stuff would better
reside=20
>in the firmware, and I have submitted related patch to the u-boot-users

>list, but I have no idea whether it would be accepted or not
(Wolfgang?).

Ah.. That. I have that in a board specific file. Looks excactly like the
implementation you have (for the 8266 port) For our internal board, it
is quite different, so it should probably be in a board specific file
(eg platforms/board_pci_setup.h)
=09
>	The main point I actually dislike in the current m8260
implementation=20
>is that it adds defines for the PCI memory map while it exists=20
>(and already included) in platforms/pq2ads.h. The memory maps are=20
>nearly the same so we should decide which one will remain.=09

I think I like the _LOWER/_UPPER/OFFSET variant. And it need to be
possible to override it in board-files.
I'll work in getting the 8266 PCI support I have to be integrated into
the PQ2[F]ADS board support.
=09
	--=20
	Sincerely,=20
	Vitaly
=09

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to thestock linux-2.5 (updated)
@ 2005-04-29 22:23 Rune Torgersen
  0 siblings, 0 replies; 8+ messages in thread
From: Rune Torgersen @ 2005-04-29 22:23 UTC (permalink / raw)
  To: Vitaly Bordug, Kumar Gala; +Cc: Tom Rini, linuxppc-embedded list

The patch works on MPC8266ADS board using PQ2FADS setup with a couple of
hacks to disable some stuff the PQ2 has that the 8266ADS doesn't

> -----Original Message-----
> From: Vitaly Bordug [mailto:vbordug@ru.mvista.com]=20
> Sent: Friday, April 29, 2005 06:29
> To: Kumar Gala
> Cc: Rune Torgersen; Wolfgang Denk; Tom Rini; linuxppc-embedded list
> Subject: Re: [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge=20
> support to thestock linux-2.5 (updated)
>=20
> Kumar,
>=20
> This is what currently intended to represent on-chip PCI=20
> bridge support=20
> for PQ2 family.
> It's approved working on my 8272 and have a very good probably of the=20
> same on the PQ2FADS-VR board. It contains low-level (SIUMCR & CPLD IC=20
> chip select ) setup only for 8272 and PQ2FADS, considering=20
> that u-boot=20
> does this stuff for 8266 boards. The actual source files are=20
> renamed to=20
> m82xx_pci.[ch].
>=20
> Rune, can you test this for m8266/8265 ? I guess while IRQ stuff is=20
> nearly the same, this _should_ work as is or with minimum=20
> effort. Note=20
> that you'll need to define PCI_INT_TO_SIU in platforms/pq2ads.h (I=20
> suppose it's the same as PQ2FADS - SIU_INT_IRQ6,  but I'm not sure).
>=20
> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
>=20
> --=20
> Sincerely,=20
> Vitaly
>=20
>=20

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to thestock linux-2.5 (updated)
@ 2005-04-21 17:42 Rune Torgersen
  0 siblings, 0 replies; 8+ messages in thread
From: Rune Torgersen @ 2005-04-21 17:42 UTC (permalink / raw)
  To: Vitaly Bordug; +Cc: Tom Rini, linuxppc-embedded list

> Another issue - I want to keep the setup of the second outbound PCI
window=20
> (pcimask1/pcibr1) - since continuous mem/mmio/io is not flexible
enough -=20
> and to keep potarx/pobarx/pocmrx assignments as they are in pq_...
version=20
> (changing of course all relative constants to _LOWER/... stuff).=20
How about initializing pcimsk1 if needed, eg have=20
#define M82XX_PCI_PRIMARY_WINDOW_SIZE
#define M82XX_PCI_PRIMARY_WINDOW_ADDR
#define M82XX_PCI_SECONDARY_WINDOW_SIZE
#define M82XX_PCI_SECONDARY_WINDOW_ADDR
And depend pcimsk1/br1 on the *_SECONDARY_WONDOW* ones

> Maybe the m8260.[c,h] should be renamed since this suites not only
826x series?
Probably to m82xx.[ch] because it is 82xx specific (I think)


Comments/objections?

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to thestock linux-2.5 (updated)
@ 2005-04-21 14:54 Rune Torgersen
  2005-04-21 15:29 ` Vitaly Bordug
  0 siblings, 1 reply; 8+ messages in thread
From: Rune Torgersen @ 2005-04-21 14:54 UTC (permalink / raw)
  To: Kumar Gala, Vitaly Bordug, Wolfgang Denk; +Cc: Tom Rini, linuxppc-embedded list

=20

> Not 100% sure.  Maybe Wolfgang or someone else know what the existing=20
> m8260 pci functionality is suppose to work with.  It seems=20
> odd that it=20
> did not have some of the bits you added for the 8272ads.  Its=20
> not clear=20
> to me if it actually worked on any systems or not.  Let see=20
> if Wolfgang=20
> has any insight as a first step.

The current one works on 8266/8265 based boards. It requires u-boot to
partiallyt set up PCI first.
I have a patch tat enables 8266ADS support, but have never posted it
(also because it has been superceded by PQ2ADS patches)

The missing pieces are the siumcr setup, which is done in U-Boot (almost
better to do it there as it is highly board dependant, and you would
have an afoul lot of #ifdefs to support all variants)

The other missing part is setup of the second outbound PCI wondow
(pcimask1/pcibr1). This is not used, bacqause the whole outbound window
is set up to be contiguous, and is covered by pcimsk0/pcibr0

I am running a slightly modified version of m8260_setup_pci on an
internal board port, and it works just fine.

Only change I'v had to do (to m8260_find bridges) is to add a bit on the
IORESOURCE_IO part, so that IO memory is detected correctly.

        pci_init_resource(&hose->io_resource,
			  MPC826x_PCI_LOWER_IO,
			  MPC826x_PCI_UPPER_IO,
			  IORESOURCE_IO | 1, "PCI I/O"); // the 1 added
so IO areas work. :FIXME: find real source

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2005-04-29 22:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-21 16:32 [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to thestock linux-2.5 (updated) Rune Torgersen
2005-04-21 17:32 ` Vitaly Bordug
2005-04-21 18:03   ` Kumar Gala
2005-04-29 11:28     ` Vitaly Bordug
  -- strict thread matches above, loose matches on Subject: below --
2005-04-29 22:23 Rune Torgersen
2005-04-21 17:42 Rune Torgersen
2005-04-21 14:54 Rune Torgersen
2005-04-21 15:29 ` Vitaly Bordug

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).