linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] Cleanup mpic nodes in .dts
Date: Mon, 2 Jun 2008 18:32:18 +0200	[thread overview]
Message-ID: <7c624bb773b7c8df8357a3b151e2d9fa@kernel.crashing.org> (raw)
In-Reply-To: <4E62E532-1E3D-4109-B6C4-152F39567CA8@kernel.crashing.org>

>>> Removed clock-frequency and big-endian props as they aren't specified
>>> anywhere.
>>
>> If you remove "big-endian", you'll have to provide some other way
>> to get that information (like, some new "compatible" value).
>
> I'm all for "big-endian" but we don't spec this anywhere and aren't 
> using it right now.  So until we have an real need to start an 
> extended mpic definition I'm getting rid of it.

If we would remove everything insufficiently documented, not much would
be left.  This doesn't seem very productive to me.  Could you instead
just add some TODO somewhere?

>> Dunno if we need "clock-frequency".
>
> Not used today.

Sure, the kernel might not use it today, but that's no reason to remove
stuff from the device tree.

I'm not against removing "clock-frequency" though, it's not 
well-defined,
and what would it be useful for anyway?

>> This patch also removes "built-in" properties.  I'm all for that,
>> but the patch description didn't say it does.
>>
> will add that to the commit message.

Thanks.


Segher

  reply	other threads:[~2008-06-02 20:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-30 20:43 [PATCH] [POWERPC] Cleanup mpic nodes in .dts Kumar Gala
2008-05-30 20:43 ` [PATCH] [POWERPC] 85xx: Add next-level-cache property Kumar Gala
2008-05-30 21:49   ` Segher Boessenkool
2008-06-02 16:15     ` Kumar Gala
2008-06-02 19:43     ` Kumar Gala
2008-06-02 21:06       ` Segher Boessenkool
2008-06-02 21:26         ` Nathan Lynch
2008-06-02 23:01           ` Kumar Gala
2008-05-30 21:42 ` [PATCH] [POWERPC] Cleanup mpic nodes in .dts Segher Boessenkool
2008-06-02 16:19   ` Kumar Gala
2008-06-02 16:32     ` Segher Boessenkool [this message]
2008-06-02 23:07       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c624bb773b7c8df8357a3b151e2d9fa@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).