Re: [PATCH v1 1/4] mm: move vma_kernel_pagesize() from hugetlb to mm.h

David Hildenbrand (Arm)
2026-03-09T13:47:13Z

On 3/9/26 14:41, Lorenzo Stoakes (Oracle) wrote:
> On Fri, Mar 06, 2026 at 02:25:51PM +0100, David Hildenbrand (Arm) wrote:
>> On 3/6/26 12:07, Lorenzo Stoakes (Oracle) wrote:
>>>
>>> LGTM, but you need to fix up VMA tests, I attach a patch below to do this. Will
>>> this resolved:
>>
>> Thanks!
>>
>> I assume that should go into patch #2 instead?
>>
>>>
>>> Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
>>
>>
>> [...]
>>
>>> ---
>>> tools/testing/vma/include/dup.h | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/tools/testing/vma/include/dup.h b/tools/testing/vma/include/dup.h
>>> index 3078ff1487d3..65b1030a7fdf 100644
>>> --- a/tools/testing/vma/include/dup.h
>>> +++ b/tools/testing/vma/include/dup.h
>>> @@ -1318,3 +1318,10 @@ static inline void vma_set_file(struct vm_area_struct *vma, struct file *file)
>>> swap(vma->vm_file, file);
>>> fput(file);
>>> }
>>> +
>>> +static inline unsigned long vma_kernel_pagesize(struct vm_area_struct *vma)
>>> +{
>>> + if (unlikely(vma->vm_ops && vma->vm_ops->pagesize))
>>> + return vma->vm_ops->pagesize(vma);
>>> + return PAGE_SIZE;
>>
>> Should we just KIS and use PAGE_SIZE for the test?
>
> Yeah that's fine, but then should go in tools/testing/vma/include/custom.h :>)

I'll place it in there, then, thanks.

--
Cheers,

David