From: Daniel Baluta <daniel.baluta@oss.nxp.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com,
Xiubo.Lee@gmail.com, nicoleotsuka@gmail.com, perex@perex.cz,
tiwai@suse.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3] ASoC: fsl_asrc_dma: allocate memory from dma device
Date: Thu, 29 Jan 2026 11:25:17 +0200 [thread overview]
Message-ID: <7e34b098-bdab-448e-a34a-02bdc643f700@oss.nxp.com> (raw)
In-Reply-To: <20260128071853.2602784-4-shengjiu.wang@nxp.com>
On 1/28/26 09:18, Shengjiu Wang wrote:
> As the dma device may support dma-coherent property on the i.MX952,
> allocate memory from dma device to make asrc driver to be compatible with
> such a case.
This commit message refers to imx952 but the change in the code apply to all supported platforms
So in not really clear what is the intention of it.
Also, it is not clear why do you allocate a pair only to free it at the end of the function.
next prev parent reply other threads:[~2026-01-29 10:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 7:18 [PATCH 0/3] ASoC: fsl_asrc: support the i.MX952 platform Shengjiu Wang
2026-01-28 7:18 ` [PATCH 1/3] ASoC: dt-bindings: fsl,imx-asrc: Add support for " Shengjiu Wang
2026-01-28 11:46 ` Krzysztof Kozlowski
2026-01-29 2:07 ` Shengjiu Wang
2026-01-28 7:18 ` [PATCH 2/3] ASoC: fsl_asrc: " Shengjiu Wang
2026-01-29 9:20 ` Daniel Baluta
2026-01-29 9:53 ` Shengjiu Wang
2026-01-29 17:14 ` Frank Li
2026-01-30 1:44 ` Shengjiu Wang
2026-01-28 7:18 ` [PATCH 3/3] ASoC: fsl_asrc_dma: allocate memory from dma device Shengjiu Wang
2026-01-29 9:25 ` Daniel Baluta [this message]
2026-01-29 9:37 ` Shengjiu Wang
2026-01-29 17:09 ` Frank Li
2026-01-30 1:52 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e34b098-bdab-448e-a34a-02bdc643f700@oss.nxp.com \
--to=daniel.baluta@oss.nxp.com \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox