From: Randy Dunlap <rdunlap@infradead.org>
To: Michael Ellerman <mpe@ellerman.id.au>, linux-kernel@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
Elimar Riesebieter <riesebie@lxtec.de>
Subject: Re: [PATCH] macintosh: via-pmu-led: *********************************
Date: Thu, 23 Feb 2023 07:51:01 -0800 [thread overview]
Message-ID: <7e5c3c59-68c1-eb45-d462-bb093aee5da3@infradead.org> (raw)
In-Reply-To: <877cw8bvzv.fsf@mpe.ellerman.id.au>
On 2/23/23 00:56, Michael Ellerman wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
>> LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
>> when ATA is not set/enabled causes a Kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
>> Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
>> Selected by [y]:
>> - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
>>
>> Fix this by making ADB_PMU_LED_DISK depend on ATA.
>
> Should it just depend on LEDS_TRIGGER_DISK ?
Hmph. Yes, good idea. Thanks.
>
>> Seen on both PPC32 and PPC64.
>>
>> Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Cc: Paul Mackerras <paulus@samba.org>
>> Cc: Elimar Riesebieter <riesebie@lxtec.de>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: linuxppc-dev@lists.ozlabs.org
>> ---
>> drivers/macintosh/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
>> --- a/drivers/macintosh/Kconfig
>> +++ b/drivers/macintosh/Kconfig
>> @@ -86,6 +86,7 @@ config ADB_PMU_LED
>>
>> config ADB_PMU_LED_DISK
>> bool "Use front LED as DISK LED by default"
>> + depends on ATA
>> depends on ADB_PMU_LED
>> depends on LEDS_CLASS
>> select LEDS_TRIGGERS
--
~Randy
prev parent reply other threads:[~2023-02-23 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 1:41 [PATCH] macintosh: via-pmu-led: ********************************* Randy Dunlap
2023-02-23 8:56 ` Michael Ellerman
2023-02-23 15:51 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e5c3c59-68c1-eb45-d462-bb093aee5da3@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=riesebie@lxtec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).