* [PATCH] macintosh: via-pmu-led: *********************************
@ 2023-02-23 1:41 Randy Dunlap
2023-02-23 8:56 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-02-23 1:41 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Paul Mackerras, linuxppc-dev, Elimar Riesebieter
LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
when ATA is not set/enabled causes a Kconfig warning:
WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
Selected by [y]:
- ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
Fix this by making ADB_PMU_LED_DISK depend on ATA.
Seen on both PPC32 and PPC64.
Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Elimar Riesebieter <riesebie@lxtec.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
---
drivers/macintosh/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -86,6 +86,7 @@ config ADB_PMU_LED
config ADB_PMU_LED_DISK
bool "Use front LED as DISK LED by default"
+ depends on ATA
depends on ADB_PMU_LED
depends on LEDS_CLASS
select LEDS_TRIGGERS
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] macintosh: via-pmu-led: *********************************
2023-02-23 1:41 [PATCH] macintosh: via-pmu-led: ********************************* Randy Dunlap
@ 2023-02-23 8:56 ` Michael Ellerman
2023-02-23 15:51 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2023-02-23 8:56 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Randy Dunlap, Paul Mackerras, linuxppc-dev, Elimar Riesebieter
Randy Dunlap <rdunlap@infradead.org> writes:
> LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
> when ATA is not set/enabled causes a Kconfig warning:
>
> WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
> Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
> Selected by [y]:
> - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
>
> Fix this by making ADB_PMU_LED_DISK depend on ATA.
Should it just depend on LEDS_TRIGGER_DISK ?
cheers
> Seen on both PPC32 and PPC64.
>
> Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Elimar Riesebieter <riesebie@lxtec.de>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
> drivers/macintosh/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -86,6 +86,7 @@ config ADB_PMU_LED
>
> config ADB_PMU_LED_DISK
> bool "Use front LED as DISK LED by default"
> + depends on ATA
> depends on ADB_PMU_LED
> depends on LEDS_CLASS
> select LEDS_TRIGGERS
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] macintosh: via-pmu-led: *********************************
2023-02-23 8:56 ` Michael Ellerman
@ 2023-02-23 15:51 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-02-23 15:51 UTC (permalink / raw)
To: Michael Ellerman, linux-kernel
Cc: Paul Mackerras, linuxppc-dev, Elimar Riesebieter
On 2/23/23 00:56, Michael Ellerman wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
>> LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
>> when ATA is not set/enabled causes a Kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
>> Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
>> Selected by [y]:
>> - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
>>
>> Fix this by making ADB_PMU_LED_DISK depend on ATA.
>
> Should it just depend on LEDS_TRIGGER_DISK ?
Hmph. Yes, good idea. Thanks.
>
>> Seen on both PPC32 and PPC64.
>>
>> Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Cc: Paul Mackerras <paulus@samba.org>
>> Cc: Elimar Riesebieter <riesebie@lxtec.de>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: linuxppc-dev@lists.ozlabs.org
>> ---
>> drivers/macintosh/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
>> --- a/drivers/macintosh/Kconfig
>> +++ b/drivers/macintosh/Kconfig
>> @@ -86,6 +86,7 @@ config ADB_PMU_LED
>>
>> config ADB_PMU_LED_DISK
>> bool "Use front LED as DISK LED by default"
>> + depends on ATA
>> depends on ADB_PMU_LED
>> depends on LEDS_CLASS
>> select LEDS_TRIGGERS
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-23 15:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-23 1:41 [PATCH] macintosh: via-pmu-led: ********************************* Randy Dunlap
2023-02-23 8:56 ` Michael Ellerman
2023-02-23 15:51 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).