From: Milton Miller <miltonm@bga.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] ppc32: remove secondary_ti
Date: Mon, 17 Nov 2008 01:46:37 -0600 [thread overview]
Message-ID: <7fd0818d9990856402b85d09b562bb51@bga.com> (raw)
In-Reply-To: <1226867161.7178.167.camel@pasglop>
On Nov 16, 2008, at 2:26 PM, Benjamin Herrenschmidt wrote:
> On Sun, 2008-11-16 at 15:43 -0600, Milton Miller wrote:
>> Instead of copying current_set[cpu] to secondary_ti, directly index
>> into
>> current_set by the cpu number like head_64.S. In addition to removing
>> the variable, a slow to respond cpu will not clobber another cpus
>> stack.
>
> Except that we don't know our CPU number at this stage do we ? IE. r24
> is our HW number, is it guaranteed to be what we want to index
> current_set ?
No, you are right, current_set is ordered by logical cpu id.
We could search the hwcpuid array similar to our search of the paca on
ppc64. But for now go ahead and reject this patch.
milton
prev parent reply other threads:[~2008-11-17 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 21:43 [PATCH] ppc32: remove secondary_ti Milton Miller
2008-11-16 20:26 ` Benjamin Herrenschmidt
2008-11-17 7:46 ` Milton Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fd0818d9990856402b85d09b562bb51@bga.com \
--to=miltonm@bga.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox