linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Hari Bathini <hbathini@linux.ibm.com>
To: Song Liu <song@kernel.org>, Naveen N Rao <naveen@kernel.org>
Cc: "Jiri Olsa" <olsajiri@gmail.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Shung-Hsi Yu" <shung-hsi.yu@suse.com>,
	bpf@vger.kernel.org, "Michael Ellerman" <mpe@ellerman.id.au>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Vishal Chourasia" <vishalc@linux.ibm.com>,
	"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
	"Miroslav Benes" <mbenes@suse.cz>,
	"Michal Suchánek" <msuchanek@suse.de>,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-trace-kernel@vger.kernel.org,
	live-patching@vger.kernel.org
Subject: Re: [BUG?] ppc64le: fentry BPF not triggered after live patch (v6.14)
Date: Mon, 7 Apr 2025 13:52:27 +0530	[thread overview]
Message-ID: <81b222ec-7635-411f-b72f-804284295edf@linux.ibm.com> (raw)
In-Reply-To: <CAPhsuW5yBLMPJy3YNoJKUfP+BEsKOgJZ_BjrJnyUQ=tMPqC7ag@mail.gmail.com>



On 04/04/25 12:03 am, Song Liu wrote:
> On Thu, Apr 3, 2025 at 8:30 AM Naveen N Rao <naveen@kernel.org> wrote:
> [...]
>>
>> We haven't addressed this particular interaction in the powerpc support
>> for ftrace direct and BPF trampolines. Right now, live patching takes
>> priority so we call the livepatch'ed function and skip further ftrace
>> direct calls.
>>
>> I'm curious if this works on arm64 with which we share support for
>> DYNAMIC_FTRACE_WITH_CALL_OPS.
> 
> We still need to land [1] for arm64 to support livepatch. In a quick test
> with [1], livepatch and bpf trampoline works together. I haven't looked
> into the arm64 JIT code, so I am not sure whether all the corner cases
> are properly handled.
> 
> [1] https://lore.kernel.org/live-patching/20250320171559.3423224-1-song@kernel.org/

Thanks for checking this on arm64, Song.
As Naveen pointed out, with out of line trampoline
on ppc64le, there are a few things to sort out with
regard to livepatch & BPF Trampoline interaction. Will
try and take a stab at it soon.

Thanks
Hari



  reply	other threads:[~2025-04-07  8:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 13:19 [BUG?] ppc64le: fentry BPF not triggered after live patch (v6.14) Shung-Hsi Yu
2025-03-31 14:09 ` Steven Rostedt
2025-04-01 12:48   ` Jiri Olsa
2025-04-03 15:26     ` Naveen N Rao
2025-04-03 18:33       ` Song Liu
2025-04-07  8:22         ` Hari Bathini [this message]
2025-10-02 19:45           ` Hari Bathini
2025-04-07  8:16 ` Hari Bathini
2025-04-07  8:42 ` Viktor Malik
2025-04-16 19:24   ` Hari Bathini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b222ec-7635-411f-b72f-804284295edf@linux.ibm.com \
    --to=hbathini@linux.ibm.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=daniel@iogearbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mahesh@linux.ibm.com \
    --cc=mark.rutland@arm.com \
    --cc=masahiroy@kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mhiramat@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=msuchanek@suse.de \
    --cc=naveen@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=olsajiri@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=shung-hsi.yu@suse.com \
    --cc=song@kernel.org \
    --cc=vishalc@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).