linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Tyrel Datwyler <tyreld@linux.ibm.com>
To: Nathan Lynch <nathanl@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: cheloha@linux.ibm.com, ldufour@linux.ibm.com
Subject: Re: [PATCH] powerpc/pseries/mobility: ignore ibm, platform-facilities updates
Date: Mon, 18 Oct 2021 16:16:37 -0700	[thread overview]
Message-ID: <822cbb54-ee68-df9a-da9f-3a25caeb72c8@linux.ibm.com> (raw)
In-Reply-To: <6de8b295-112f-651e-a18e-3ab3e499ad69@linux.ibm.com>

On 10/18/21 3:37 PM, Tyrel Datwyler wrote:
> On 10/18/21 9:34 AM, Nathan Lynch wrote:

<<snip>>

>>
>> One way to address that would be to make the drivers respond to node
>> removal notifications, so that node references can be dropped
>> appropriately. But this would likely force the drivers to disrupt active
>> clients for no useful purpose: equivalent nodes are immediately re-added.
>> And recall that the acceleration capabilities described by the nodes remain
>> available throughout the whole process.
> 
> See my comments above about its the vio bus more at fault here then the drivers
> themselves. I'm inclined to agree though that disrupting active operations with
> a driver unbind/rebind is a little extreme.
> 
> This also brings me back to firmware removing and re-adding the whole
> '/ibm,platform-facilities' node instead of simply updating changed properties
> could avoid this whole fiasco.
> 

Thinking more on this and trying to recall my discussion so very long ago with
firmware I now recall that I had complained that the idea of a node remove/add
is akin to a DLPAR operation which we have no notion of for platform facilities.
They know better than to do this with other virtual devices so I'm still not
sure why they insist on doing it here.

-Tyrel

  reply	other threads:[~2021-10-18 23:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 16:34 [PATCH] powerpc/pseries/mobility: ignore ibm, platform-facilities updates Nathan Lynch
2021-10-18 22:37 ` Tyrel Datwyler
2021-10-18 23:16   ` Tyrel Datwyler [this message]
2021-10-19  9:05   ` Laurent Dufour
2021-10-19 21:43     ` [PATCH] powerpc/pseries/mobility: ignore ibm,platform-facilities updates Nathan Lynch
2021-10-19 21:36   ` Nathan Lynch
2021-10-19 23:02     ` [PATCH] powerpc/pseries/mobility: ignore ibm, platform-facilities updates Tyrel Datwyler
2021-10-20 15:54       ` [PATCH] powerpc/pseries/mobility: ignore ibm,platform-facilities updates Nathan Lynch
2021-10-20 17:34         ` [PATCH] powerpc/pseries/mobility: ignore ibm, platform-facilities updates Tyrel Datwyler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=822cbb54-ee68-df9a-da9f-3a25caeb72c8@linux.ibm.com \
    --to=tyreld@linux.ibm.com \
    --cc=cheloha@linux.ibm.com \
    --cc=ldufour@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nathanl@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).