From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8E34BDE0A8 for ; Sat, 26 Jul 2008 05:38:40 +1000 (EST) Message-Id: <83A1F423-1C8B-405D-9118-D9BB51A8AA94@kernel.crashing.org> From: Kumar Gala To: Kumar Gala In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v926) Subject: Re: [RFC] 4xx hardware watchpoint support Date: Fri, 25 Jul 2008 14:38:28 -0500 References: <1211391577.6232.15.camel@gargoyle> <18484.60888.981390.893747@cargo.ozlabs.ibm.com> <1213992894.6635.41.camel@gargoyle> <20080719093752.5aada45c@zod.rchland.ibm.com> <1216658194.5727.36.camel@gargoyle> <20080721130551.23a06006@zod.rchland.ibm.com> <1216777678.5727.82.camel@gargoyle> <20080723115321.53aa655b@zod.rchland.ibm.com> <1216829442.5727.97.camel@gargoyle> <1216958433.11188.70.camel@pasglop> Cc: Paul Mackerras , Christoph Hellwig , ppc-dev List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Jul 25, 2008, at 10:23 AM, Kumar Gala wrote: > > On Jul 24, 2008, at 11:00 PM, Benjamin Herrenschmidt wrote: > >> On Wed, 2008-07-23 at 13:10 -0300, Luis Machado wrote: >>> On Wed, 2008-07-23 at 11:53 -0400, Josh Boyer wrote: >>>> Shouldn't this (and other places) be: >>>> >>>> #if defined(CONFIG_44x) || defined(CONFIG_BOOKE) >>>> >>>> if you are going to exclude 40x for now? Otherwise this is still >>>> enabled on 405 and setting the wrong register. >>>> >>>> josh >>> >>> Yes, sorry. I wasn't aware of this specific define value. It makes >>> things easier to support 405's later. >>> >>> Like so? >> >> Please, next time, when you re-send a patch like that, re-include >> the full subject and patch description. You can add then blurbs after >> the --- line if you want to add things that won't make it to git. >> >> I'll deal with that specific one for now. > > Ben, I want to make sure this works on FSL Book-E before it gets > into tree and I need to think about what SMP issues it might have. > > I talked to Josh about this at OLS and if you are ok I can deal with > acceptance of this patch via my tree. Josh pointed out that you went ahead and merged this. Curse you :) I've got a patch in my tree to address my initial concerns. - k