Re: [PATCH 1/1] crypto: Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.

[Danny Tsen <dtsen@linux.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

Yes, checkpath was run.

Not sure what you mean by "some indentation changes.(This can't go with 
fixes patch, will just add the noise)"

Thanks.

On 9/13/24 1:22 AM, Kamlesh Gurudasani wrote:
> Michael Ellerman<mpe@ellerman.id.au> writes:
>
>> Danny Tsen<dtsen@linux.ibm.com> writes:
>>> This patch is to fix an issue when simd is not usable that data mismatch
>>> may occur over ipsec tunnel. The fix is to register algs as SIMD modules
>>> so that the algorithm is excecuted when SIMD instructions is usable.
>>>
>>> A new module rfc4106(gcm(aes)) is also added. Re-write AES/GCM assembly
>>> codes with smaller footprints and small performance gain.
>>>
>>> This patch has been tested with the kernel crypto module tcrypt.ko and
>>> has passed the selftest.  The patch is also tested with
>>> CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled.
>>>
>>> Signed-off-by: Danny Tsen<dtsen@linux.ibm.com>
>>> ---
>>>   arch/powerpc/crypto/Kconfig            |    1 +
>>>   arch/powerpc/crypto/aes-gcm-p10-glue.c |  141 +-
>>>   arch/powerpc/crypto/aes-gcm-p10.S      | 2421 +++++++++++-------------
>>>   3 files changed, 1187 insertions(+), 1376 deletions(-)
>> As this is a bug fix it should have a Fixes: tag, and probably a stable
>> Cc as well.
>>
>> But that diffstat is really large for a bug fix. Is there no way to fix
>> the issue in a smaller patch? Even if that is just disabling the feature
>> until it can be fixed in subsequent commits?
>>
>> cheers
> The commit message says "The fix is to register algs as SIMD modules"
>
> and
>
> "A new module rfc4106(gcm(aes)) is also added."
>
> and I also see some indentation changes.(This can't go with fixes patch,
> will just add the noise)
>
> Would suggest to break the patch in three.
>
> I see a big subject line, have you ran the checkpatch?
>
> Kamlesh
>

[-- Attachment #2: Type: text/html, Size: 2736 bytes --]