linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/mm: Don't report PUDs as memory leaks when using kmemleak
Date: Mon, 30 Jul 2018 11:54:22 +0200	[thread overview]
Message-ID: <83c5b57f-f11d-3223-4d24-5030799caa0c@molgen.mpg.de> (raw)
In-Reply-To: <87zhy9i5q0.fsf@concordia.ellerman.id.au>

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

Dear Michael,


On 07/30/18 08:43, Michael Ellerman wrote:
> Paul Menzel <pmenzel@molgen.mpg.de> writes:
>> Am 19.07.2018 um 16:33 schrieb Michael Ellerman:
> ...
>>>
>>> The fix is fairly simple. We need to tell kmemleak to ignore PUD
>>> allocations and never report them as leaks. We can also tell it not to
>>> scan the PGD, because it will never find pointers in there. However it
>>> will still notice if we allocate a PGD and then leak it.
>>>
>>> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
>>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > ---
>>>   arch/powerpc/include/asm/book3s/64/pgalloc.h | 23 +++++++++++++++++++++--
>>>   1 file changed, 21 insertions(+), 2 deletions(-)
>>
>> […]
>>
>> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de> on IBM S822LC
> 
> Thanks.

No problem. I forgot to add, that it’d be great, if you tagged this
for the stable series too.

Cc: stable@vger.kernel.org


Kind regards,

Paul


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]

  reply	other threads:[~2018-07-30  9:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 14:33 [PATCH] powerpc/mm: Don't report PUDs as memory leaks when using kmemleak Michael Ellerman
2018-07-29 13:35 ` Paul Menzel
2018-07-30  6:43   ` Michael Ellerman
2018-07-30  9:54     ` Paul Menzel [this message]
2018-08-03 10:23       ` Michael Ellerman
2018-08-01  5:24 ` Michael Ellerman
2018-08-06 17:06 ` [PATCH] " Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83c5b57f-f11d-3223-4d24-5030799caa0c@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).