linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Rob Herring <robh@kernel.org>
Cc: Darren Stevens <darren@stevens-zone.net>,
	mad skateman <madskateman@gmail.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"R.T.Dickinson" <rtd2@xtra.co.nz>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Christian Zigotzky <info@xenosoft.de>
Subject: Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19
Date: Mon, 30 May 2022 07:26:15 +0200	[thread overview]
Message-ID: <83ff7361-d54c-ac39-9ccb-0926c3a3d8e2@xenosoft.de> (raw)
In-Reply-To: <CAL_JsqLN6bT=YhyRTVWU2WmG-htCujtCROQuK+gdMUHMSHVeaQ@mail.gmail.com>

On 27 May 2022 at 04:23 pm, Rob Herring wrote:
> The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
> resources to a child platform device. Can you try the following
> change:
>
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index 44a7e58a26e3..47d9b7be60da 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
>                                          const char *name, int id)
>   {
>          struct platform_device *pdev;
> -       const struct resource *res = ofdev->resource;
> -       unsigned int num = ofdev->num_resources;
>          int retval;
>
>          pdev = platform_device_alloc(name, id);
> @@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register(
>          if (retval)
>                  goto error;
>
> -       if (num) {
> -               retval = platform_device_add_resources(pdev, res, num);
> -               if (retval)
> -                       goto error;
> -       }
> +       pdev->dev.of_node = ofdev->dev.of_node;
>
>          retval = platform_device_add(pdev);
>          if (retval)
Hello Rob,

Thanks a lot for your patch! Unfortunately, this leads to a boot loop. 
Do you have another idea?

Thanks,
Christian

  parent reply	other threads:[~2022-05-30  5:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 17:42 [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19 Christian Zigotzky
2022-05-27  7:23 ` Christophe Leroy
2022-05-27  7:48   ` Christian Zigotzky
2022-05-27  7:54     ` Fwd: " Christian Zigotzky
2022-05-27  7:56   ` Prabhakar Mahadev Lad
2022-05-27  8:06     ` Christian Zigotzky
2022-05-27  8:14       ` Prabhakar Mahadev Lad
2022-05-27  8:32         ` Christian Zigotzky
2022-05-27 14:23           ` Rob Herring
2022-05-28  8:05             ` Christian Zigotzky
2022-05-28  8:44               ` Christophe Leroy
2022-05-28 10:01               ` Christian Zigotzky
2022-05-30  5:26             ` Christian Zigotzky [this message]
2022-05-31 13:45               ` Rob Herring
2022-05-31 16:29                 ` Christian Zigotzky
2022-06-01 12:35                   ` Rob Herring
2022-06-04 13:12                     ` Christian Zigotzky
2022-06-01  2:10                 ` Christian Zigotzky
2022-06-06 14:58             ` Rob Herring
2022-06-06 16:13               ` Christian Zigotzky
2022-06-06 17:06                 ` Rob Herring
2022-06-09 18:03                   ` Christian Zigotzky
2022-06-13 15:57                     ` Rob Herring
2022-06-16 17:04                       ` Christian Zigotzky
  -- strict thread matches above, loose matches on Subject: below --
2022-05-26 17:49 Christian Zigotzky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ff7361-d54c-ac39-9ccb-0926c3a3d8e2@xenosoft.de \
    --to=chzigotzky@xenosoft.de \
    --cc=darren@stevens-zone.net \
    --cc=info@xenosoft.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madskateman@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=rtd2@xtra.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).