linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: Small fixes for the Ebony device tree
Date: Tue, 15 May 2007 07:11:07 +0200	[thread overview]
Message-ID: <8492e53122b6e1ba269afd53b48a4968@kernel.crashing.org> (raw)
In-Reply-To: <20070515020026.GG565@localhost.localdomain>

Just a few more things...

>  	plb {
> -		device_type = "ibm,plb";
>  		compatible = "ibm,plb-440gp", "ibm,plb4";

You match on "ibm,plb" though.  Well you got one
in three right ;-)

> +		SDRAM0: memory-controller {
>  			compatible = "ibm,sdram-440gp", "ibm,sdram";

"ibm,sdram" is way too generic to ever be usefully
used for device matching.

> +		SRAM0: sram {
> +			compatible = "ibm,sram440gp";

You spell this one without a dash, all others with one.


Segher

  reply	other threads:[~2007-05-15  5:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15  2:00 Small fixes for the Ebony device tree David Gibson
2007-05-15  5:11 ` Segher Boessenkool [this message]
2007-05-15  5:47   ` David Gibson
2007-05-15  6:11     ` Stefan Roese
2007-05-15  6:18       ` David Gibson
2007-05-15  6:28         ` Segher Boessenkool
2007-05-15  6:34           ` David Gibson
2007-05-15  6:47             ` Segher Boessenkool
2007-05-15  6:58               ` David Gibson
2007-05-15  7:07                 ` Segher Boessenkool
2007-05-16  3:47                   ` David Gibson
2007-05-15  6:46         ` Stefan Roese
2007-05-15  7:02           ` Segher Boessenkool
  -- strict thread matches above, loose matches on Subject: below --
2007-05-16  3:48 David Gibson
2007-05-16 13:35 ` Segher Boessenkool
2007-05-14  4:54 David Gibson
2007-05-14 12:22 ` Josh Boyer
2007-05-14 12:59 ` Segher Boessenkool
2007-05-14 15:09   ` Josh Boyer
2007-05-15  1:17   ` David Gibson
2007-05-15  4:59     ` Segher Boessenkool
2007-05-15  5:46       ` David Gibson
2007-05-16  3:47         ` David Gibson
2007-05-15 18:15 ` Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8492e53122b6e1ba269afd53b48a4968@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).