From: "Matvejchikov Ilya" <matvejchikov@gmail.com>
To: "Laurent Pinchart" <laurentp@cse-semaphore.com>
Cc: linuxppc-dev@ozlabs.org, Bill Fink <billfink@mindspring.com>,
vbordug@ru.mvista.com, netdev@vger.kernel.org
Subject: Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()
Date: Fri, 20 Jun 2008 12:55:22 +0400 [thread overview]
Message-ID: <8496f91a0806200155hcb1f440ld7b5f678d95fdb85@mail.gmail.com> (raw)
In-Reply-To: <200806201025.28768.laurentp@cse-semaphore.com>
>> > diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c
>> > index ce40cf9..1a95cf1 100644
>> > --- a/drivers/net/fs_enet/mac-fcc.c
>> > +++ b/drivers/net/fs_enet/mac-fcc.c
>> > @@ -464,6 +464,9 @@ static void restart(struct net_device *dev)
>> > C32(fccp, fcc_fpsmr, FCC_PSMR_FDE | FCC_PSMR_LPB);
>> >
>> > S32(fccp, fcc_gfmr, FCC_GFMR_ENR | FCC_GFMR_ENT);
>> > +
>> > + /* Restore multicast and promiscous settings */
>> > + set_multicast_list(dev);
>> > }
Is it right to call set_multicast_list() after turning on transmitter
and receiver? May be swap this lines around?
next prev parent reply other threads:[~2008-06-20 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 15:07 [PATCH] fs_enet: restore promiscuous and multicast settings in restart() Laurent Pinchart
2008-06-18 18:45 ` Matvejchikov Ilya
2008-06-19 18:20 ` Vitaly Bordug
2008-06-19 18:47 ` Jon Loeliger
2008-06-19 19:15 ` Olof Johansson
2008-06-19 19:41 ` Matvejchikov Ilya
2008-06-20 3:01 ` Bill Fink
2008-06-20 8:25 ` Laurent Pinchart
2008-06-20 8:55 ` Matvejchikov Ilya [this message]
2008-06-26 9:38 ` Laurent Pinchart
2008-06-20 17:50 ` Bill Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8496f91a0806200155hcb1f440ld7b5f678d95fdb85@mail.gmail.com \
--to=matvejchikov@gmail.com \
--cc=billfink@mindspring.com \
--cc=laurentp@cse-semaphore.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).