From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CF54D2C0185 for ; Tue, 15 Oct 2013 06:26:34 +1100 (EST) Subject: Re: [PATCH] powerpc/qe_lib: Share the qe_lib for the others architecture Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <1381750622-1150-1-git-send-email-X.Xie@freescale.com> Date: Mon, 14 Oct 2013 14:26:24 -0500 Message-Id: <8559CF98-88E4-4271-A873-1409359EFE5C@kernel.crashing.org> References: <1381750622-1150-1-git-send-email-X.Xie@freescale.com> To: Xie Xiaobo Cc: scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Oct 14, 2013, at 6:37 AM, Xie Xiaobo wrote: > The QUICC Engine (QE) is a communications coprocessors on Freescale > embedded processors. The QE had been applied in PowerPC architecture > previously, and it will be applied in ARM architecture too. > So move the qe_lib from arch/powerpc to driver/ firstly. >=20 > Signed-off-by: Xie Xiaobo > --- > arch/powerpc/Kconfig | 2 - > arch/powerpc/include/asm/immap_qe.h | 491 ----------------- > arch/powerpc/include/asm/qe.h | 740 = ------------------------- > arch/powerpc/include/asm/qe_ic.h | 144 ----- > arch/powerpc/include/asm/ucc.h | 64 --- > arch/powerpc/include/asm/ucc_fast.h | 244 -------- > arch/powerpc/include/asm/ucc_slow.h | 290 ---------- > arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +- > arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 4 +- > arch/powerpc/platforms/Kconfig | 19 - > arch/powerpc/sysdev/Makefile | 1 - > arch/powerpc/sysdev/qe_lib/Kconfig | 27 - > arch/powerpc/sysdev/qe_lib/Makefile | 10 - > arch/powerpc/sysdev/qe_lib/gpio.c | 317 ----------- > arch/powerpc/sysdev/qe_lib/qe.c | 708 = ------------------------ > arch/powerpc/sysdev/qe_lib/qe_ic.c | 501 ----------------- > arch/powerpc/sysdev/qe_lib/qe_ic.h | 103 ---- > arch/powerpc/sysdev/qe_lib/qe_io.c | 218 -------- > arch/powerpc/sysdev/qe_lib/ucc.c | 213 ------- > arch/powerpc/sysdev/qe_lib/ucc_fast.c | 364 ------------ > arch/powerpc/sysdev/qe_lib/ucc_slow.c | 380 ------------- > arch/powerpc/sysdev/qe_lib/usb.c | 56 -- > drivers/Kconfig | 2 + > drivers/Makefile | 3 + > drivers/net/ethernet/freescale/fsl_pq_mdio.c | 2 +- > drivers/net/ethernet/freescale/ucc_geth.c | 8 +- > drivers/net/ethernet/freescale/ucc_geth.h | 8 +- > drivers/qe/Kconfig | 51 ++ > drivers/qe/Makefile | 10 + > drivers/qe/gpio.c | 317 +++++++++++ > drivers/qe/qe.c | 708 = ++++++++++++++++++++++++ > drivers/qe/qe_common.c | 187 +++++++ > drivers/qe/qe_ic.c | 501 +++++++++++++++++ > drivers/qe/qe_ic.h | 103 ++++ > drivers/qe/qe_io.c | 218 ++++++++ > drivers/qe/ucc.c | 213 +++++++ > drivers/qe/ucc_fast.c | 364 ++++++++++++ > drivers/qe/ucc_slow.c | 380 +++++++++++++ > drivers/qe/usb.c | 56 ++ > drivers/spi/spi-fsl-cpm.c | 2 +- > drivers/tty/serial/ucc_uart.c | 2 +- > include/qe/immap_qe.h | 491 +++++++++++++++++ > include/qe/qe.h | 794 = +++++++++++++++++++++++++++ > include/qe/qe_ic.h | 144 +++++ > include/qe/ucc.h | 64 +++ > include/qe/ucc_fast.h | 244 ++++++++ > include/qe/ucc_slow.h | 290 ++++++++++ > 47 files changed, 5155 insertions(+), 4907 deletions(-) > delete mode 100644 arch/powerpc/include/asm/immap_qe.h > delete mode 100644 arch/powerpc/include/asm/qe.h > delete mode 100644 arch/powerpc/include/asm/qe_ic.h > delete mode 100644 arch/powerpc/include/asm/ucc.h > delete mode 100644 arch/powerpc/include/asm/ucc_fast.h > delete mode 100644 arch/powerpc/include/asm/ucc_slow.h > delete mode 100644 arch/powerpc/sysdev/qe_lib/Kconfig > delete mode 100644 arch/powerpc/sysdev/qe_lib/Makefile > delete mode 100644 arch/powerpc/sysdev/qe_lib/gpio.c > delete mode 100644 arch/powerpc/sysdev/qe_lib/qe.c > delete mode 100644 arch/powerpc/sysdev/qe_lib/qe_ic.c > delete mode 100644 arch/powerpc/sysdev/qe_lib/qe_ic.h > delete mode 100644 arch/powerpc/sysdev/qe_lib/qe_io.c > delete mode 100644 arch/powerpc/sysdev/qe_lib/ucc.c > delete mode 100644 arch/powerpc/sysdev/qe_lib/ucc_fast.c > delete mode 100644 arch/powerpc/sysdev/qe_lib/ucc_slow.c > delete mode 100644 arch/powerpc/sysdev/qe_lib/usb.c > create mode 100644 drivers/qe/Kconfig > create mode 100644 drivers/qe/Makefile > create mode 100644 drivers/qe/gpio.c > create mode 100644 drivers/qe/qe.c > create mode 100644 drivers/qe/qe_common.c > create mode 100644 drivers/qe/qe_ic.c > create mode 100644 drivers/qe/qe_ic.h > create mode 100644 drivers/qe/qe_io.c > create mode 100644 drivers/qe/ucc.c > create mode 100644 drivers/qe/ucc_fast.c > create mode 100644 drivers/qe/ucc_slow.c > create mode 100644 drivers/qe/usb.c > create mode 100644 include/qe/immap_qe.h > create mode 100644 include/qe/qe.h > create mode 100644 include/qe/qe_ic.h > create mode 100644 include/qe/ucc.h > create mode 100644 include/qe/ucc_fast.h > create mode 100644 include/qe/ucc_slow.h Before this is moved you should address the PPC specific issues in the = code. Use of PPC_LIB_RHEAP, the IO macros which are not cross platform, = etc. Also, copy linux-kernel list as I'm not sure drivers/qe would be the = recommendation location for this to end up at. - k=