From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70984C30653 for ; Thu, 4 Jul 2024 08:29:33 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=pDH/NlOy; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WF8vc0DNmz3fS5 for ; Thu, 4 Jul 2024 18:29:32 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=pDH/NlOy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=maz@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WF8tJ0Y0Bz3fS4 for ; Thu, 4 Jul 2024 18:28:24 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 44ED56256A; Thu, 4 Jul 2024 08:28:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE6D3C3277B; Thu, 4 Jul 2024 08:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720081699; bh=6hGIw3dGd3aMp5e6MG7Mw6yQmhyNFDXqXn4N3IV6BOM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pDH/NlOy0EnoCnKiqthrmDakLYAtXPbPZJN68zWCfqI4PwNTwVf55tf+MApcQ25YZ Ext8UICd3yf0wsqkFW1bW686bDqy5NbW6jHj8qv3ptDJn2NDVIl12XEqDEsLbVCZQh n1GOZ3XpS1XJ/QJoRBIm+na3gX7oStwltIeBKl+W5w4I62k/n4R6FKasYjlAGj/lOW Gfk2qmMRD4J+V2LyfJ4I8vD/Wlc1DMoJi7WAll/PD+o+x1MFFTSUpkz1lwiIb3b7ya 1gWspKy8tpl4P5uk1/2suKLeRbNLNcEgfkXI3ADJu9TzVVqNfjHy7qz8QS9RIkcLyF gmi5dLK3mrs0Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sPHpA-009ghh-2H; Thu, 04 Jul 2024 09:28:16 +0100 Date: Thu, 04 Jul 2024 09:28:07 +0100 Message-ID: <86ed894l48.wl-maz@kernel.org> From: Marc Zyngier To: Christian Zigotzky Subject: Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29 In-Reply-To: References: <3ab66fab-c3f2-4bed-a04d-a10c57dcdd9b@xenosoft.de> <86zfqzhgys.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: chzigotzky@xenosoft.de, robh@kernel.org, apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, madskateman@gmail.com, rtd2@xtra.co.nz, matthew@a-eon.biz, darren@stevens-zone.net, info@xenosoft.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: apatel@ventanamicro.com, Rob Herring , Darren Stevens , "R.T.Dickinson" , DTML , Linux Kernel Mailing List , mad skateman , Matthew Leaman , linuxppc-dev , Christian Zigotzky Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 04 Jul 2024 05:10:46 +0100, Christian Zigotzky wrote: > > On 02.07.24 18:54, Marc Zyngier wrote: > > On Sun, 30 Jun 2024 11:21:55 +0100, > > Christian Zigotzky wrote: > >> Hello, > >> > >> There is an issue with the identification of ATA drives with our > >> P.A. Semi Nemo boards [1] after the > >> commit "of/irq: Factor out parsing of interrupt-map parent > >> phandle+args from of_irq_parse_raw()" [2]. > > [snip] > > > > My earlier request for valuable debug information still stands. But > > while you're at it, can you please give the following hack a go? > > > > M. > > > > --- a/drivers/of/irq.c > > +++ b/drivers/of/irq.c > > @@ -282,8 +282,10 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq) > > oldimap = imap; > > imap = of_irq_parse_imap_parent(oldimap, imaplen, out_irq); > > - if (!imap) > > - goto fail; > > + if (!imap) { > > + match = 0; > > + break; > > + } > > match &= of_device_is_available(out_irq->np); > > if (match) > > > > This may not be the final workaround even if it solves your boot > > problem, but will at least give us a hint at what is going wrong. > > > > I have the fuzzy feeling that we may be able to lob this broken system > > as part of the of_irq_imap_abusers[] array, which would solve things > > pretty "neatly". > > > > M. > > > We tested this patch yesterday and it solves the boot problem. How about the other patch[1], which would be far preferable? M. [1] https://lore.kernel.org/all/86ed8ba2sp.wl-maz@kernel.org -- Without deviation from the norm, progress is not possible.