From: Michael Neuling <mikey@neuling.org>
To: Kumar Gala <kumar.gala@freescale.com>, benh@kernel.crashing.org
Cc: linux-ppc list <linuxppc-dev@ozlabs.org>
Subject: [PATCH] powerpc: Fix potential compile error irqs_disabled_flags
Date: Thu, 22 Oct 2009 17:15:43 +1100 [thread overview]
Message-ID: <8702.1256192143@neuling.org> (raw)
In-Reply-To: <58391C58-B57E-47A8-ACE3-0272C3CF223F@freescale.com>
irqs_disabled_flags is #defined in linux/irqflags.h when
CONFIG_TRACE_IRQFLAGS_SUPPORT is enabled. 64 and 32 bit always have
CONFIG_TRACE_IRQFLAGS_SUPPORT enabled so just remove
irqs_disabled_flags.
This fixes the case when someone needs to include both linux/irqflags.h
and asm/hw_irq.h.
Signed-off-by: Michael Neuling <mikey@neuling.org>
---
> I think you can just remove irqs_disabled_flags as we always have
> CONFIG_TRACE_IRQFLAGS_SUPPORT (for both 32 and 64).
Ok, thanks kumar.
arch/powerpc/include/asm/hw_irq.h | 5 -----
1 file changed, 5 deletions(-)
Index: linux-2.6-ozlabs/arch/powerpc/include/asm/hw_irq.h
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/include/asm/hw_irq.h
+++ linux-2.6-ozlabs/arch/powerpc/include/asm/hw_irq.h
@@ -64,11 +64,6 @@ extern void iseries_handle_interrupts(vo
get_paca()->hard_enabled = 0; \
} while(0)
-static inline int irqs_disabled_flags(unsigned long flags)
-{
- return flags == 0;
-}
-
#else
#if defined(CONFIG_BOOKE)
prev parent reply other threads:[~2009-10-22 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 5:58 [PATCH] powerpc: Fix potential compile error irqs_disabled_flags Michael Neuling
2009-10-22 6:03 ` Kumar Gala
2009-10-22 6:15 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8702.1256192143@neuling.org \
--to=mikey@neuling.org \
--cc=benh@kernel.crashing.org \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).