From: Nathan Lynch <nathanl@linux.ibm.com>
To: Waiman Long <longman@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org,
Laurent Dufour <ldufour@linux.ibm.com>,
Zhang Xiaoxu <zhangxiaoxu5@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/pseries/cpuhp: Use alloc_cpumask_var() in pseries_cpu_hotplug_init()
Date: Mon, 08 Nov 2021 20:07:58 -0600 [thread overview]
Message-ID: <871r3qjd35.fsf@linux.ibm.com> (raw)
In-Reply-To: <a90f0361-329b-1e21-90c1-601d6f7c2f24@redhat.com>
Waiman Long <longman@redhat.com> writes:
> On 11/8/21 20:46, Nicholas Piggin wrote:
>> Differences between the two patches are error checking - no big deal but
>> we should just do it. And GFP_NOWAIT - is this required here?
>
> As I have replied in another thread, I added it because it was used in
> memblock_alloc_internal().
From the pseries code's point of view, that's an incidental property of
the misuse detection branch in memblock_alloc_internal() -- I'd
speculate to make it robust for calls from atomic context. GFP_NOWAIT is
not needed here.
prev parent reply other threads:[~2021-11-09 2:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 16:47 [PATCH] powerpc/pseries/cpuhp: Use alloc_cpumask_var() in pseries_cpu_hotplug_init() Waiman Long
2021-11-08 23:06 ` Nathan Lynch
2021-11-09 1:48 ` Waiman Long
2021-11-09 1:04 ` Michael Ellerman
2021-11-09 1:43 ` Waiman Long
2021-11-09 1:46 ` Nicholas Piggin
2021-11-09 1:51 ` Waiman Long
2021-11-09 2:07 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r3qjd35.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=danielhb413@gmail.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=longman@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).