From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BADF2E6BF33 for ; Fri, 30 Jan 2026 17:27:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4f2jd32DFpz2xl0; Sat, 31 Jan 2026 04:27:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1769794055; cv=none; b=TrAzEo2d3oikTdyncbwO1icLcGnJ+3DVgT2lB0X1zD+cpeXva3ibXW+kXizHXEknp1Oc/hUyq+uVq1g4LgByycJKhUEIHDm/07gm7xnPHtymKJH9Blr1dOQr/c+rCqqNj3ZvcJDA8d6UEgiXlaR+SRJwok/29mmqonab5bcg7k6xzfRqLuJurjQLeSXqH3kN2OSmae3S1BbIdNPCQq3awyH+QQzhzZa2cwuI3U2vbVGSj7vKN5tTOcIFU7nCIFrg5r/rgfYfqrkuh0boBCm2wxU4Vtab1VnLtMc8OzeznhqYqpJRfqoPEHuagSVNv0kI04N+vRD5C8xSlcH0IPvvoQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1769794055; c=relaxed/relaxed; bh=o3M3i7fOsBJJ8QZ7iZoiOC82WHRYdzsj5QwfB37tvhM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hcGD1gGjJcb5vROreECEkX+/N9UXkknB4uDNgUQkPtd+EY3LA7Wmq//YjTqIfKmoxvamH5+hvJ68EGdcbtD7/WLa1g+taw2Lx0mzOHHnDDwck3+wuhaDe0QMkiT4mi59DAWOqTcoR+LFRooyIPBJtB0wC/ia/yQS1Z7stBy8mKQRR3LmOhI7HKxwAyjx42YnHHtchcOXtrNaFzjqoxltAQ33WvXFlq0H7LfS5jgrT+XA7fqmkCa5Q59QbsnH2yZq8t98mCIfKGRKuEYtgNTSsn5+aaeV1G0Jt+a0JZu9LnfXibl/S+Iehgozdyk07hUgn0bA5UNSdhJeg4YR+R3P9A== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=4vjFnCId; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=520kqiAp; dkim-atps=neutral; spf=pass (client-ip=193.142.43.55; helo=galois.linutronix.de; envelope-from=john.ogness@linutronix.de; receiver=lists.ozlabs.org) smtp.mailfrom=linutronix.de Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=4vjFnCId; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=520kqiAp; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linutronix.de (client-ip=193.142.43.55; helo=galois.linutronix.de; envelope-from=john.ogness@linutronix.de; receiver=lists.ozlabs.org) Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4f2jd23nYgz2xQr for ; Sat, 31 Jan 2026 04:27:34 +1100 (AEDT) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1769794048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o3M3i7fOsBJJ8QZ7iZoiOC82WHRYdzsj5QwfB37tvhM=; b=4vjFnCIdprQ4bapgrR0W30E28e5XqGnWTzlLJRIchP5KT0mQiU7C2HocIuX1Kdz8pUDo0Y qc+5Orpl1l1vZoFNRQKL24RKcgRr4rbqO02DrPCVc+5aUzHom7b8+oniEw+b53sZSdrxJg +9kDxpq15AQ1xIFUPYwfQgdiBumRwsh+faRgD4dNJMyLkXr/A+P3jXB+CHRA0Hld9eIR+Y 7xvqnLxeTCF6EQZwTVn1wPEr2oy9Q/+88+eiC8F7PD8kB/n3dpKOZdgpjEsqUgdQZXqqI6 yQRXOGphajl9ppYkFrEud4nWZdOCa3/Ob9kGErESIR3cRVjE/LChlCPSJd3YTA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1769794048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o3M3i7fOsBJJ8QZ7iZoiOC82WHRYdzsj5QwfB37tvhM=; b=520kqiApVkDPFPboRTL5PTkP4fVPei7/H7ecnPwf1SVFxrBJQEXzDTADXeZGZGuaQ0gr4c ZZ61wAzhpOPpFsDw== To: Marcos Paulo de Souza , Richard Weinberger , Anton Ivanov , Johannes Berg , Greg Kroah-Hartman , Jason Wessel , Daniel Thompson , Douglas Anderson , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Jiri Slaby , Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geert Uytterhoeven , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Andreas Larsson , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Jacky Huang , Shan-Chun Hung , Laurentiu Tudor Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org, netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-hardening@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, Marcos Paulo de Souza Subject: Re: [PATCH 05/19] printk: Add more context to suspend/resume functions In-Reply-To: <20251227-printk-cleanup-part3-v1-5-21a291bcf197@suse.com> References: <20251227-printk-cleanup-part3-v1-0-21a291bcf197@suse.com> <20251227-printk-cleanup-part3-v1-5-21a291bcf197@suse.com> Date: Fri, 30 Jan 2026 18:33:27 +0106 Message-ID: <87343n3ta8.fsf@jogness.linutronix.de> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain On 2025-12-27, Marcos Paulo de Souza wrote: > The new comments clarifies from where the functions are supposed to be > called. > > Signed-off-by: Marcos Paulo de Souza > --- > kernel/printk/printk.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index 173c14e08afe..85a8b6521d9e 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -2734,7 +2734,8 @@ MODULE_PARM_DESC(console_no_auto_verbose, "Disable console loglevel raise to hig > /** > * console_suspend_all - suspend the console subsystem > * > - * This disables printk() while we go into suspend states > + * This disables printk() while we go into suspend states. Called by the power > + * management subsystem. Since you are touching this comment, I would prefer to make it technically accurate. It is not printk() that is disabled, it is console printing that is disabled. Perhaps something like: * Block all console printing while the system goes into suspend state. * Called by the power management subsystem. > */ > void console_suspend_all(void) > { > @@ -2766,6 +2767,12 @@ void console_suspend_all(void) > synchronize_srcu(&console_srcu); > } > > +/** > + * console_resume_all - resume the console subsystem > + * > + * This resumes printk() when the system is being restored. Called by the power > + * management subsystem. And something similar here: * Allow all console printing when the system resumes from suspend. Called by * the power management system. > + */ > void console_resume_all(void) > { > struct console_flush_type ft; John Ogness