* [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE
@ 2025-04-07 8:40 Madhavan Srinivasan
2025-04-07 17:03 ` Venkat Rao Bagalkote
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Madhavan Srinivasan @ 2025-04-07 8:40 UTC (permalink / raw)
To: mpe, npiggin, christophe.leroy, paulus
Cc: naveen, linuxppc-dev, Madhavan Srinivasan, kernel test robot
Commit 3d45a3d0d2e6 ("powerpc: Define config option for processors with broadcast TLBIE")
added a config option PPC_RADIX_BROADCAST_TLBIE to support processors with
broadcast TLBIE. Since this option is relevant only for RADIX_MMU, add
a check as a dependency to enable PPC_RADIX_BROADCAST_TLBIE in both
powernv and pseries configs. This fixes the unmet config dependency
warning reported
WARNING: unmet direct dependencies detected for PPC_RADIX_BROADCAST_TLBIE
Depends on [n]: PPC_RADIX_MMU [=n]
Selected by [y]:
- PPC_PSERIES [=y] && PPC64 [=y] && PPC_BOOK3S [=y]
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504051857.jRqxM60c-lkp@intel.com/
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
---
arch/powerpc/platforms/powernv/Kconfig | 2 +-
arch/powerpc/platforms/pseries/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig
index 3fbe0295ce14..95d7ba73d43d 100644
--- a/arch/powerpc/platforms/powernv/Kconfig
+++ b/arch/powerpc/platforms/powernv/Kconfig
@@ -17,7 +17,7 @@ config PPC_POWERNV
select MMU_NOTIFIER
select FORCE_SMP
select ARCH_SUPPORTS_PER_VMA_LOCK
- select PPC_RADIX_BROADCAST_TLBIE
+ select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
default y
config OPAL_PRD
diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig
index a934c2a262f6..fa3c2fff082a 100644
--- a/arch/powerpc/platforms/pseries/Kconfig
+++ b/arch/powerpc/platforms/pseries/Kconfig
@@ -23,7 +23,7 @@ config PPC_PSERIES
select FORCE_SMP
select SWIOTLB
select ARCH_SUPPORTS_PER_VMA_LOCK
- select PPC_RADIX_BROADCAST_TLBIE
+ select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
default y
config PARAVIRT
--
2.48.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE
2025-04-07 8:40 [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE Madhavan Srinivasan
@ 2025-04-07 17:03 ` Venkat Rao Bagalkote
2025-04-07 19:10 ` Ritesh Harjani (IBM)
2025-04-21 9:41 ` Madhavan Srinivasan
2 siblings, 0 replies; 6+ messages in thread
From: Venkat Rao Bagalkote @ 2025-04-07 17:03 UTC (permalink / raw)
To: Madhavan Srinivasan, mpe, npiggin, christophe.leroy, paulus
Cc: naveen, linuxppc-dev, kernel test robot
On 07/04/25 2:10 pm, Madhavan Srinivasan wrote:
> Commit 3d45a3d0d2e6 ("powerpc: Define config option for processors with broadcast TLBIE")
> added a config option PPC_RADIX_BROADCAST_TLBIE to support processors with
> broadcast TLBIE. Since this option is relevant only for RADIX_MMU, add
> a check as a dependency to enable PPC_RADIX_BROADCAST_TLBIE in both
> powernv and pseries configs. This fixes the unmet config dependency
> warning reported
>
> WARNING: unmet direct dependencies detected for PPC_RADIX_BROADCAST_TLBIE
> Depends on [n]: PPC_RADIX_MMU [=n]
> Selected by [y]:
> - PPC_PSERIES [=y] && PPC64 [=y] && PPC_BOOK3S [=y]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504051857.jRqxM60c-lkp@intel.com/
> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Tested this on pseries LPAR and the patch fixes the reported issue. Hence,
Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> ---
> arch/powerpc/platforms/powernv/Kconfig | 2 +-
> arch/powerpc/platforms/pseries/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig
> index 3fbe0295ce14..95d7ba73d43d 100644
> --- a/arch/powerpc/platforms/powernv/Kconfig
> +++ b/arch/powerpc/platforms/powernv/Kconfig
> @@ -17,7 +17,7 @@ config PPC_POWERNV
> select MMU_NOTIFIER
> select FORCE_SMP
> select ARCH_SUPPORTS_PER_VMA_LOCK
> - select PPC_RADIX_BROADCAST_TLBIE
> + select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
> default y
>
> config OPAL_PRD
> diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig
> index a934c2a262f6..fa3c2fff082a 100644
> --- a/arch/powerpc/platforms/pseries/Kconfig
> +++ b/arch/powerpc/platforms/pseries/Kconfig
> @@ -23,7 +23,7 @@ config PPC_PSERIES
> select FORCE_SMP
> select SWIOTLB
> select ARCH_SUPPORTS_PER_VMA_LOCK
> - select PPC_RADIX_BROADCAST_TLBIE
> + select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
> default y
>
> config PARAVIRT
With out this patch:
make olddefconfig
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
HOSTCC scripts/kconfig/confdata.o
HOSTCC scripts/kconfig/expr.o
LEX scripts/kconfig/lexer.lex.c
YACC scripts/kconfig/parser.tab.[ch]
HOSTCC scripts/kconfig/lexer.lex.o
HOSTCC scripts/kconfig/menu.o
HOSTCC scripts/kconfig/parser.tab.o
HOSTCC scripts/kconfig/preprocess.o
HOSTCC scripts/kconfig/symbol.o
HOSTCC scripts/kconfig/util.o
HOSTLD scripts/kconfig/conf
WARNING: unmet direct dependencies detected for PPC_RADIX_BROADCAST_TLBIE
Depends on [n]: PPC_RADIX_MMU [=n]
Selected by [y]:
- PPC_PSERIES [=y] && PPC64 [=y] && PPC_BOOK3S [=y]
#
# configuration written to .config
#
With this patch:
make olddefconfig
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
HOSTCC scripts/kconfig/confdata.o
HOSTCC scripts/kconfig/expr.o
LEX scripts/kconfig/lexer.lex.c
YACC scripts/kconfig/parser.tab.[ch]
HOSTCC scripts/kconfig/lexer.lex.o
HOSTCC scripts/kconfig/menu.o
HOSTCC scripts/kconfig/parser.tab.o
HOSTCC scripts/kconfig/preprocess.o
HOSTCC scripts/kconfig/symbol.o
HOSTCC scripts/kconfig/util.o
HOSTLD scripts/kconfig/conf
#
# No change to .config
#
Regards,
Venkat.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE
2025-04-07 8:40 [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE Madhavan Srinivasan
2025-04-07 17:03 ` Venkat Rao Bagalkote
@ 2025-04-07 19:10 ` Ritesh Harjani (IBM)
2025-04-08 6:02 ` Christophe Leroy
2025-04-21 9:41 ` Madhavan Srinivasan
2 siblings, 1 reply; 6+ messages in thread
From: Ritesh Harjani (IBM) @ 2025-04-07 19:10 UTC (permalink / raw)
To: Madhavan Srinivasan, mpe, npiggin, christophe.leroy, paulus
Cc: naveen, linuxppc-dev, Madhavan Srinivasan, kernel test robot
Madhavan Srinivasan <maddy@linux.ibm.com> writes:
> Commit 3d45a3d0d2e6 ("powerpc: Define config option for processors with broadcast TLBIE")
We may need to add above to Fixes tag as well, no?
> added a config option PPC_RADIX_BROADCAST_TLBIE to support processors with
> broadcast TLBIE. Since this option is relevant only for RADIX_MMU, add
> a check as a dependency to enable PPC_RADIX_BROADCAST_TLBIE in both
> powernv and pseries configs. This fixes the unmet config dependency
> warning reported
>
> WARNING: unmet direct dependencies detected for PPC_RADIX_BROADCAST_TLBIE
> Depends on [n]: PPC_RADIX_MMU [=n]
> Selected by [y]:
> - PPC_PSERIES [=y] && PPC64 [=y] && PPC_BOOK3S [=y]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504051857.jRqxM60c-lkp@intel.com/
> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
It's a bit strange that even though PPC_RADIX_BROADCAST_TLBIE adds
PPC_RADIX_MMU as a dependency where is it defined, we still have to add
an extra check for the same dependency to enable this for any platform.
The config generated by the 0day in the shared link, indeed had an unmet
dependency. i.e.
CONFIG_PPC_64S_HASH_MMU=y
# CONFIG_PPC_RADIX_MMU is not set
CONFIG_PPC_RADIX_BROADCAST_TLBIE=y
So, the fix look good to me. Please feel free to take:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> ---
> arch/powerpc/platforms/powernv/Kconfig | 2 +-
> arch/powerpc/platforms/pseries/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig
> index 3fbe0295ce14..95d7ba73d43d 100644
> --- a/arch/powerpc/platforms/powernv/Kconfig
> +++ b/arch/powerpc/platforms/powernv/Kconfig
> @@ -17,7 +17,7 @@ config PPC_POWERNV
> select MMU_NOTIFIER
> select FORCE_SMP
> select ARCH_SUPPORTS_PER_VMA_LOCK
> - select PPC_RADIX_BROADCAST_TLBIE
> + select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
> default y
>
> config OPAL_PRD
> diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig
> index a934c2a262f6..fa3c2fff082a 100644
> --- a/arch/powerpc/platforms/pseries/Kconfig
> +++ b/arch/powerpc/platforms/pseries/Kconfig
> @@ -23,7 +23,7 @@ config PPC_PSERIES
> select FORCE_SMP
> select SWIOTLB
> select ARCH_SUPPORTS_PER_VMA_LOCK
> - select PPC_RADIX_BROADCAST_TLBIE
> + select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
> default y
>
> config PARAVIRT
> --
> 2.48.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE
2025-04-07 19:10 ` Ritesh Harjani (IBM)
@ 2025-04-08 6:02 ` Christophe Leroy
2025-04-08 9:01 ` Ritesh Harjani
0 siblings, 1 reply; 6+ messages in thread
From: Christophe Leroy @ 2025-04-08 6:02 UTC (permalink / raw)
To: Ritesh Harjani (IBM), Madhavan Srinivasan, mpe, npiggin,
christophe.leroy, paulus
Cc: naveen, linuxppc-dev, kernel test robot
Le 07/04/2025 à 21:10, Ritesh Harjani (IBM) a écrit :
> Madhavan Srinivasan <maddy@linux.ibm.com> writes:
>
>> Commit 3d45a3d0d2e6 ("powerpc: Define config option for processors with broadcast TLBIE")
>
> We may need to add above to Fixes tag as well, no?
>
>> added a config option PPC_RADIX_BROADCAST_TLBIE to support processors with
>> broadcast TLBIE. Since this option is relevant only for RADIX_MMU, add
>> a check as a dependency to enable PPC_RADIX_BROADCAST_TLBIE in both
>> powernv and pseries configs. This fixes the unmet config dependency
>> warning reported
>>
>> WARNING: unmet direct dependencies detected for PPC_RADIX_BROADCAST_TLBIE
>> Depends on [n]: PPC_RADIX_MMU [=n]
>> Selected by [y]:
>> - PPC_PSERIES [=y] && PPC64 [=y] && PPC_BOOK3S [=y]
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202504051857.jRqxM60c-lkp@intel.com/
>> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
>
> It's a bit strange that even though PPC_RADIX_BROADCAST_TLBIE adds
> PPC_RADIX_MMU as a dependency where is it defined, we still have to add
> an extra check for the same dependency to enable this for any platform.
That's expected, see
https://docs.kernel.org/kbuild/kconfig-language.html#menu-attributes :
select should be used with care. select will force a symbol to a value
without visiting the dependencies. By abusing select you are able to
select a symbol FOO even if FOO depends on BAR that is not set. In
general use select only for non-visible symbols (no prompts anywhere)
and for symbols with no dependencies. That will limit the usefulness but
on the other hand avoid the illegal configurations all over.
Christophe
>
> The config generated by the 0day in the shared link, indeed had an unmet
> dependency. i.e.
>
> CONFIG_PPC_64S_HASH_MMU=y
> # CONFIG_PPC_RADIX_MMU is not set
> CONFIG_PPC_RADIX_BROADCAST_TLBIE=y
>
>
> So, the fix look good to me. Please feel free to take:
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
>
>
>> ---
>> arch/powerpc/platforms/powernv/Kconfig | 2 +-
>> arch/powerpc/platforms/pseries/Kconfig | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig
>> index 3fbe0295ce14..95d7ba73d43d 100644
>> --- a/arch/powerpc/platforms/powernv/Kconfig
>> +++ b/arch/powerpc/platforms/powernv/Kconfig
>> @@ -17,7 +17,7 @@ config PPC_POWERNV
>> select MMU_NOTIFIER
>> select FORCE_SMP
>> select ARCH_SUPPORTS_PER_VMA_LOCK
>> - select PPC_RADIX_BROADCAST_TLBIE
>> + select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
>> default y
>>
>> config OPAL_PRD
>> diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig
>> index a934c2a262f6..fa3c2fff082a 100644
>> --- a/arch/powerpc/platforms/pseries/Kconfig
>> +++ b/arch/powerpc/platforms/pseries/Kconfig
>> @@ -23,7 +23,7 @@ config PPC_PSERIES
>> select FORCE_SMP
>> select SWIOTLB
>> select ARCH_SUPPORTS_PER_VMA_LOCK
>> - select PPC_RADIX_BROADCAST_TLBIE
>> + select PPC_RADIX_BROADCAST_TLBIE if PPC_RADIX_MMU
>> default y
>>
>> config PARAVIRT
>> --
>> 2.48.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE
2025-04-08 6:02 ` Christophe Leroy
@ 2025-04-08 9:01 ` Ritesh Harjani
0 siblings, 0 replies; 6+ messages in thread
From: Ritesh Harjani @ 2025-04-08 9:01 UTC (permalink / raw)
To: Christophe Leroy, Madhavan Srinivasan, mpe, npiggin,
christophe.leroy, paulus
Cc: naveen, linuxppc-dev, kernel test robot
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 07/04/2025 à 21:10, Ritesh Harjani (IBM) a écrit :
>> Madhavan Srinivasan <maddy@linux.ibm.com> writes:
>>
>>> Commit 3d45a3d0d2e6 ("powerpc: Define config option for processors with broadcast TLBIE")
>>
>> We may need to add above to Fixes tag as well, no?
>>
>>> added a config option PPC_RADIX_BROADCAST_TLBIE to support processors with
>>> broadcast TLBIE. Since this option is relevant only for RADIX_MMU, add
>>> a check as a dependency to enable PPC_RADIX_BROADCAST_TLBIE in both
>>> powernv and pseries configs. This fixes the unmet config dependency
>>> warning reported
>>>
>>> WARNING: unmet direct dependencies detected for PPC_RADIX_BROADCAST_TLBIE
>>> Depends on [n]: PPC_RADIX_MMU [=n]
>>> Selected by [y]:
>>> - PPC_PSERIES [=y] && PPC64 [=y] && PPC_BOOK3S [=y]
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202504051857.jRqxM60c-lkp@intel.com/
>>> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
>>
>> It's a bit strange that even though PPC_RADIX_BROADCAST_TLBIE adds
>> PPC_RADIX_MMU as a dependency where is it defined, we still have to add
>> an extra check for the same dependency to enable this for any platform.
>
> That's expected, see
Yes. I had figured that out.
> https://docs.kernel.org/kbuild/kconfig-language.html#menu-attributes :
Ok! Good to see we have this properly documented as well. Thanks for
pointing out the documentation link.
>
> select should be used with care. select will force a symbol to a value
> without visiting the dependencies. By abusing select you are able to
> select a symbol FOO even if FOO depends on BAR that is not set. In
> general use select only for non-visible symbols (no prompts anywhere)
> and for symbols with no dependencies. That will limit the usefulness but
> on the other hand avoid the illegal configurations all over.
>
> Christophe
>
Make sense. Thanks! for adding the details.
-ritesh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE
2025-04-07 8:40 [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE Madhavan Srinivasan
2025-04-07 17:03 ` Venkat Rao Bagalkote
2025-04-07 19:10 ` Ritesh Harjani (IBM)
@ 2025-04-21 9:41 ` Madhavan Srinivasan
2 siblings, 0 replies; 6+ messages in thread
From: Madhavan Srinivasan @ 2025-04-21 9:41 UTC (permalink / raw)
To: mpe, npiggin, christophe.leroy, paulus, Madhavan Srinivasan
Cc: naveen, linuxppc-dev, kernel test robot
On Mon, 07 Apr 2025 14:10:29 +0530, Madhavan Srinivasan wrote:
> Commit 3d45a3d0d2e6 ("powerpc: Define config option for processors with broadcast TLBIE")
> added a config option PPC_RADIX_BROADCAST_TLBIE to support processors with
> broadcast TLBIE. Since this option is relevant only for RADIX_MMU, add
> a check as a dependency to enable PPC_RADIX_BROADCAST_TLBIE in both
> powernv and pseries configs. This fixes the unmet config dependency
> warning reported
>
> [...]
Applied to powerpc/fixes.
[1/1] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE
https://git.kernel.org/powerpc/c/3700976f2ae8dfec4c17433f8a16c9e6c334cf89
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-04-21 9:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07 8:40 [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE Madhavan Srinivasan
2025-04-07 17:03 ` Venkat Rao Bagalkote
2025-04-07 19:10 ` Ritesh Harjani (IBM)
2025-04-08 6:02 ` Christophe Leroy
2025-04-08 9:01 ` Ritesh Harjani
2025-04-21 9:41 ` Madhavan Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).