linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Rob Herring (Arm)" <robh@kernel.org>,
	Saravana Kannan <saravanak@google.com>,
	linuxppc-dev@lists.ozlabs.org, Conor Dooley <conor@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling
Date: Thu, 14 Nov 2024 13:07:49 +1100	[thread overview]
Message-ID: <874j4ava8a.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <CAMuHMdWk83QpTcbuBz=m6UZ+ShFM4rTt_UL-frzR3LmAf_Tb2Q@mail.gmail.com>

Geert Uytterhoeven <geert@linux-m68k.org> writes:
> On Thu, Nov 7, 2024 at 12:37 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>> "Rob Herring (Arm)" <robh@kernel.org> writes:
>> > While OpenFirmware originally allowed walking parent nodes and default
>> > root values for #address-cells and #size-cells, FDT has long required
>> > explicit values. It's been a warning in dtc for the root node since the
>> > beginning (2005) and for any parent node since 2007. Of course, not all
>> > FDT uses dtc, but that should be the majority by far. The various
>> > extracted OF devicetrees I have dating back to the 1990s (various
>> > PowerMac, OLPC, PASemi Nemo) all have explicit root node properties.
>>
>> I have various old device trees that have been given to me over the
>> years, and as far as I can tell they all have these properties (some of
>> them are partial trees so it's hard to be 100% sure).
>
> Apparently CHRP LongTrail only had #address-cells in the root node.
> Interestingly, /cpus does have a (zero) @size-cells property.
> http://g33rt.be/migrated/Linux/PPC/root.html
> http://g33rt.be/migrated/Linux/PPC/DeviceTree.html
>
> No idea if any of them are still alive.

OK. We could fix that up in prom_init() if necessary - there's already a
bunch of workarounds in there for longtrail.

cheers


  reply	other threads:[~2024-11-14  2:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20241108110444eucas1p20cbed7533af31573dac30dbb435c3d9d@eucas1p2.samsung.com>
2024-11-06 17:10 ` [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling Rob Herring (Arm)
2024-11-07 11:35   ` Michael Ellerman
2024-11-08  8:48     ` Geert Uytterhoeven
2024-11-14  2:07       ` Michael Ellerman [this message]
2024-11-14 12:54     ` Segher Boessenkool
2024-11-15 14:10       ` Rob Herring
2024-11-26  3:36     ` Michael Ellerman
2024-11-27 21:42       ` Segher Boessenkool
2024-12-02 14:18         ` Rob Herring
2024-12-02 22:04           ` Segher Boessenkool
2024-12-02 22:55             ` Rob Herring
2024-12-05 22:01               ` Herrenschmidt, Benjamin
2024-11-08 11:04   ` Marek Szyprowski
2024-11-08 13:25     ` Rob Herring
2024-11-08 15:28       ` Marek Szyprowski
2024-11-08 13:26     ` Steven Price
2024-11-08 14:04       ` Rob Herring
2024-11-08 14:33         ` Steven Price
2024-11-08 14:58           ` Rob Herring
2024-11-08 15:29             ` Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874j4ava8a.fsf@mpe.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=robh@kernel.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).