LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Masahiro Yamada <masahiroy@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
	"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, Daniel Axtens <dja@axtens.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: remove unused *_syscall_64.o variables in Makefile
Date: Tue, 20 Feb 2024 16:43:56 +1100	[thread overview]
Message-ID: <874je31yhv.fsf@mail.lhotse> (raw)
In-Reply-To: <CAK7LNARFNoAUUiGMP95pTi_rSxSi5Z0HJo2kBC472f0koMr2mA@mail.gmail.com>

Masahiro Yamada <masahiroy@kernel.org> writes:
> +To: Daniel Axtens

Unfortunately dja doesn't work on the kernel anymore.

> Maybe, we should check if the issue fixed by
> 2f26ed1764b42a8c40d9c48441c73a70d805decf
> came back.

That crash is specific to Power8, which probably no one is running
syzkaller on anymore.

If I enable KCOV and boot with 1T segments disabled (to make it easier
to trigger the bug) it crashes similarly to the report in that commit.

> On Fri, Feb 16, 2024 at 10:55 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
...
>> To restore the original behavior, we could replace them with:
>>
>>   GCOV_PROFILE_interrupt.o := n
>>   KCOV_INSTRUMENT_interrupt.o := n
>>   UBSAN_SANITIZE_interrupt.o := n

But just putting those back isn't actually enough to fix it, the code
has changed and there are other places that need KCOV disabled on P8.

So I'm not sure how to handle this one. I guess I might just take it and
then make a todo to fix the KCOV problems later.

cheers

  reply	other threads:[~2024-02-20  5:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 13:55 [PATCH] powerpc: remove unused *_syscall_64.o variables in Makefile Masahiro Yamada
2024-02-17  1:06 ` Masahiro Yamada
2024-02-20  5:43   ` Michael Ellerman [this message]
2024-05-08 13:39 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874je31yhv.fsf@mail.lhotse \
    --to=mpe@ellerman.id.au \
    --cc=aneesh.kumar@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dja@axtens.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=masahiroy@kernel.org \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox