From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Michael Ellerman <patch-notifications@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Rob Herring <robh@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: powermac: Use of_get_cpu_hwid() to read CPU node 'reg'
Date: Tue, 15 Aug 2023 14:01:01 +1000 [thread overview]
Message-ID: <874jl1dkea.fsf@mail.lhotse> (raw)
In-Reply-To: <f97e8c26-1379-dabc-21af-ebf4b06b31e7@wanadoo.fr>
Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> Le 03/07/2023 à 07:26, Michael Ellerman a écrit :
>> On Sun, 19 Mar 2023 09:59:31 -0500, Rob Herring wrote:
>>> Replace open coded reading of CPU nodes' "reg" properties with
>>> of_get_cpu_hwid() dedicated for this purpose.
>>>
>>>
>>
>> Applied to powerpc/next.
>>
>> [1/1] powerpc: powermac: Use of_get_cpu_hwid() to read CPU node 'reg'
>> https://git.kernel.org/powerpc/c/bc1cf75027585f8d87f94e464ee5909acf885a8c
>>
>> cheers
>>
>
> Hi,
>
> I guess, that it does not really matter, but shouldn't the
> of_node_put() be *after* the "reset_io = *rst;" statements to be
> absolutely safe?
Technically yes.
> (This change is in my backlog and I have apparently never proposed it)
Can you rebase and resend?
cheers
prev parent reply other threads:[~2023-08-15 4:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 14:59 [PATCH] powerpc: powermac: Use of_get_cpu_hwid() to read CPU node 'reg' Rob Herring
2023-07-03 5:26 ` Michael Ellerman
2023-07-03 17:01 ` Christophe JAILLET
2023-07-03 17:04 ` Marion & Christophe JAILLET
2023-08-15 4:01 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jl1dkea.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=patch-notifications@ellerman.id.au \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).