* Re: [PATCH] cachestat: wire up cachestat for other architectures
2023-05-10 19:58 [PATCH] cachestat: wire up cachestat for other architectures Nhat Pham
@ 2023-05-11 3:23 ` Michael Ellerman
2023-05-11 19:34 ` Nhat Pham
2023-05-11 7:01 ` Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Michael Ellerman @ 2023-05-11 3:23 UTC (permalink / raw)
To: Nhat Pham, akpm
Cc: dalias, linux-ia64, linux-sh, linux-mips, James.Bottomley,
linux-mm, sparclinux, agordeev, linux-arch, linux-s390, ysato,
deller, linux, geert, mattst88, borntraeger, linux-alpha, gor,
hca, kernel-team, richard.henderson, npiggin, linux-m68k, ink,
glaubitz, linux-arm-kernel, chris, monstr, tsbogend, linux-parisc,
jcmvbkbc, linux-api, linux-kernel, svens, hannes, linuxppc-dev,
davem
Nhat Pham <nphamcs@gmail.com> writes:
> cachestat is previously only wired in for x86 (and architectures using
> the generic unistd.h table):
>
> https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/
>
> This patch wires cachestat in for all the other architectures.
>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ---
> arch/alpha/kernel/syscalls/syscall.tbl | 1 +
> arch/arm/tools/syscall.tbl | 1 +
> arch/ia64/kernel/syscalls/syscall.tbl | 1 +
> arch/m68k/kernel/syscalls/syscall.tbl | 1 +
> arch/microblaze/kernel/syscalls/syscall.tbl | 1 +
> arch/mips/kernel/syscalls/syscall_n32.tbl | 1 +
> arch/mips/kernel/syscalls/syscall_n64.tbl | 1 +
> arch/mips/kernel/syscalls/syscall_o32.tbl | 1 +
> arch/parisc/kernel/syscalls/syscall.tbl | 1 +
> arch/powerpc/kernel/syscalls/syscall.tbl | 1 +
With the change to the selftest (see my other mail), I tested this on
powerpc and all tests pass.
Tested-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] cachestat: wire up cachestat for other architectures
2023-05-11 3:23 ` Michael Ellerman
@ 2023-05-11 19:34 ` Nhat Pham
0 siblings, 0 replies; 8+ messages in thread
From: Nhat Pham @ 2023-05-11 19:34 UTC (permalink / raw)
To: Michael Ellerman
Cc: dalias, linux-ia64, linux-sh, linux-mips, James.Bottomley,
linux-mm, sparclinux, agordeev, linux-arch, linux-s390, ysato,
deller, linux, geert, mattst88, borntraeger, linux-alpha, gor,
hca, kernel-team, richard.henderson, npiggin, linux-m68k, ink,
glaubitz, linux-arm-kernel, chris, monstr, tsbogend, linux-parisc,
jcmvbkbc, linux-api, linux-kernel, svens, hannes, akpm,
linuxppc-dev, davem
On Wed, May 10, 2023 at 8:23 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Nhat Pham <nphamcs@gmail.com> writes:
> > cachestat is previously only wired in for x86 (and architectures using
> > the generic unistd.h table):
> >
> > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/
> >
> > This patch wires cachestat in for all the other architectures.
> >
> > Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> > ---
> > arch/alpha/kernel/syscalls/syscall.tbl | 1 +
> > arch/arm/tools/syscall.tbl | 1 +
> > arch/ia64/kernel/syscalls/syscall.tbl | 1 +
> > arch/m68k/kernel/syscalls/syscall.tbl | 1 +
> > arch/microblaze/kernel/syscalls/syscall.tbl | 1 +
> > arch/mips/kernel/syscalls/syscall_n32.tbl | 1 +
> > arch/mips/kernel/syscalls/syscall_n64.tbl | 1 +
> > arch/mips/kernel/syscalls/syscall_o32.tbl | 1 +
> > arch/parisc/kernel/syscalls/syscall.tbl | 1 +
> > arch/powerpc/kernel/syscalls/syscall.tbl | 1 +
>
> With the change to the selftest (see my other mail), I tested this on
> powerpc and all tests pass.
Saw the change you proposed, Michael! It looks good to me.
Thanks for helping me make the selftest suite more robust :)
>
> Tested-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
>
>
> cheers
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cachestat: wire up cachestat for other architectures
2023-05-10 19:58 [PATCH] cachestat: wire up cachestat for other architectures Nhat Pham
2023-05-11 3:23 ` Michael Ellerman
@ 2023-05-11 7:01 ` Geert Uytterhoeven
2023-05-11 9:01 ` Nhat Pham
2023-05-11 7:04 ` Arnd Bergmann
2023-05-11 7:57 ` Heiko Carstens
3 siblings, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2023-05-11 7:01 UTC (permalink / raw)
To: Nhat Pham
Cc: dalias, linux-ia64, linux-sh, linux-mips, James.Bottomley,
linux-mm, sparclinux, agordeev, linux-arch, linux-s390, ysato,
deller, linux, mattst88, borntraeger, linux-alpha, gor, hca,
kernel-team, richard.henderson, npiggin, linux-m68k, ink,
glaubitz, linux-arm-kernel, chris, monstr, tsbogend, linux-parisc,
jcmvbkbc, linux-api, linux-kernel, svens, hannes, akpm,
linuxppc-dev, davem
Hi Nat,
On Wed, May 10, 2023 at 9:58 PM Nhat Pham <nphamcs@gmail.com> wrote:
> cachestat is previously only wired in for x86 (and architectures using
> the generic unistd.h table):
>
> https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/
>
> This patch wires cachestat in for all the other architectures.
>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ---
> arch/alpha/kernel/syscalls/syscall.tbl | 1 +
> arch/arm/tools/syscall.tbl | 1 +
Looking at the last addition of a syscall (commit 21b084fdf2a49ca1
("mm/mempolicy: wire up syscall set_mempolicy_home_node"), it looks
like you forgot to update arm64 in compat mode? Or is that not needed?
> arch/ia64/kernel/syscalls/syscall.tbl | 1 +
> arch/m68k/kernel/syscalls/syscall.tbl | 1 +
For m68k:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> arch/microblaze/kernel/syscalls/syscall.tbl | 1 +
> arch/mips/kernel/syscalls/syscall_n32.tbl | 1 +
> arch/mips/kernel/syscalls/syscall_n64.tbl | 1 +
> arch/mips/kernel/syscalls/syscall_o32.tbl | 1 +
> arch/parisc/kernel/syscalls/syscall.tbl | 1 +
> arch/powerpc/kernel/syscalls/syscall.tbl | 1 +
> arch/s390/kernel/syscalls/syscall.tbl | 1 +
> arch/sh/kernel/syscalls/syscall.tbl | 1 +
> arch/sparc/kernel/syscalls/syscall.tbl | 1 +
> arch/xtensa/kernel/syscalls/syscall.tbl | 1 +
> 14 files changed, 14 insertions(+)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] cachestat: wire up cachestat for other architectures
2023-05-11 7:01 ` Geert Uytterhoeven
@ 2023-05-11 9:01 ` Nhat Pham
0 siblings, 0 replies; 8+ messages in thread
From: Nhat Pham @ 2023-05-11 9:01 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: dalias, linux-ia64, linux-sh, linux-mips, James.Bottomley,
linux-mm, sparclinux, agordeev, linux-arch, linux-s390, ysato,
deller, linux, mattst88, borntraeger, linux-alpha, gor, hca,
kernel-team, richard.henderson, npiggin, linux-m68k, ink,
glaubitz, linux-arm-kernel, chris, monstr, tsbogend, linux-parisc,
jcmvbkbc, linux-api, linux-kernel, svens, hannes, akpm,
linuxppc-dev, davem
On Thu, May 11, 2023 at 12:01 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> Hi Nat,
>
> On Wed, May 10, 2023 at 9:58 PM Nhat Pham <nphamcs@gmail.com> wrote:
> > cachestat is previously only wired in for x86 (and architectures using
> > the generic unistd.h table):
> >
> > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/
> >
> > This patch wires cachestat in for all the other architectures.
> >
> > Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> > ---
> > arch/alpha/kernel/syscalls/syscall.tbl | 1 +
> > arch/arm/tools/syscall.tbl | 1 +
>
> Looking at the last addition of a syscall (commit 21b084fdf2a49ca1
> ("mm/mempolicy: wire up syscall set_mempolicy_home_node"), it looks
> like you forgot to update arm64 in compat mode? Or is that not needed?
It does look like I missed that! Thanks for the reminder. I'll send a fixlet
shortly...
Best,
Nhat
>
> > arch/ia64/kernel/syscalls/syscall.tbl | 1 +
> > arch/m68k/kernel/syscalls/syscall.tbl | 1 +
>
> For m68k:
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> > arch/microblaze/kernel/syscalls/syscall.tbl | 1 +
> > arch/mips/kernel/syscalls/syscall_n32.tbl | 1 +
> > arch/mips/kernel/syscalls/syscall_n64.tbl | 1 +
> > arch/mips/kernel/syscalls/syscall_o32.tbl | 1 +
> > arch/parisc/kernel/syscalls/syscall.tbl | 1 +
> > arch/powerpc/kernel/syscalls/syscall.tbl | 1 +
> > arch/s390/kernel/syscalls/syscall.tbl | 1 +
> > arch/sh/kernel/syscalls/syscall.tbl | 1 +
> > arch/sparc/kernel/syscalls/syscall.tbl | 1 +
> > arch/xtensa/kernel/syscalls/syscall.tbl | 1 +
> > 14 files changed, 14 insertions(+)
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cachestat: wire up cachestat for other architectures
2023-05-10 19:58 [PATCH] cachestat: wire up cachestat for other architectures Nhat Pham
2023-05-11 3:23 ` Michael Ellerman
2023-05-11 7:01 ` Geert Uytterhoeven
@ 2023-05-11 7:04 ` Arnd Bergmann
2023-05-11 9:30 ` Nhat Pham
2023-05-11 7:57 ` Heiko Carstens
3 siblings, 1 reply; 8+ messages in thread
From: Arnd Bergmann @ 2023-05-11 7:04 UTC (permalink / raw)
To: Nhat Pham, Andrew Morton
Cc: Rich Felker, linux-ia64, linux-sh, linux-mips,
James E . J . Bottomley, linux-mm, sparclinux, Alexander Gordeev,
Linux-Arch, linux-s390, Yoshinori Sato, Helge Deller,
Russell King, Geert Uytterhoeven, Matt Turner, borntraeger,
linux-alpha, gor, Heiko Carstens, kernel-team, Richard Henderson,
Nicholas Piggin, linux-m68k, Ivan Kokshaysky,
John Paul Adrian Glaubitz, linux-arm-kernel, chris, Michal Simek,
Thomas Bogendoerfer, linux-parisc, Max Filippov, linux-api,
linux-kernel, Sven Schnelle, Johannes Weiner, linuxppc-dev,
David S . Miller
On Wed, May 10, 2023, at 21:58, Nhat Pham wrote:
> cachestat is previously only wired in for x86 (and architectures using
> the generic unistd.h table):
>
> https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/
>
> This patch wires cachestat in for all the other architectures.
>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
The changes you did here look good, but you missed one
file that has never been converted to the syscall.tbl format:
arch/arm64/include/asm/unistd32.h along with the __NR_compat_syscalls
definition in arch/arm64/include/asm/unistd.h, please add those
as well, and then
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cachestat: wire up cachestat for other architectures
2023-05-11 7:04 ` Arnd Bergmann
@ 2023-05-11 9:30 ` Nhat Pham
0 siblings, 0 replies; 8+ messages in thread
From: Nhat Pham @ 2023-05-11 9:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rich Felker, linux-ia64, linux-sh, linux-mips,
James E . J . Bottomley, linux-mm, sparclinux, Alexander Gordeev,
Linux-Arch, linux-s390, Yoshinori Sato, Helge Deller,
Russell King, Geert Uytterhoeven, Matt Turner, borntraeger,
linux-alpha, gor, Heiko Carstens, kernel-team, Richard Henderson,
Nicholas Piggin, linux-m68k, Ivan Kokshaysky,
John Paul Adrian Glaubitz, linux-arm-kernel, chris, Michal Simek,
Thomas Bogendoerfer, linux-parisc, Max Filippov, linux-api,
linux-kernel, Sven Schnelle, Johannes Weiner, Andrew Morton,
linuxppc-dev, David S . Miller
On Thu, May 11, 2023 at 12:05 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Wed, May 10, 2023, at 21:58, Nhat Pham wrote:
> > cachestat is previously only wired in for x86 (and architectures using
> > the generic unistd.h table):
> >
> > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/
> >
> > This patch wires cachestat in for all the other architectures.
> >
> > Signed-off-by: Nhat Pham <nphamcs@gmail.com>
>
> The changes you did here look good, but you missed one
> file that has never been converted to the syscall.tbl format:
> arch/arm64/include/asm/unistd32.h along with the __NR_compat_syscalls
> definition in arch/arm64/include/asm/unistd.h, please add those
> as well, and then
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Just sent a follow-up fixlet for this:
https://lore.kernel.org/linux-mm/20230511092843.3896327-1-nphamcs@gmail.com/T/#u
Thanks for the suggestion!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cachestat: wire up cachestat for other architectures
2023-05-10 19:58 [PATCH] cachestat: wire up cachestat for other architectures Nhat Pham
` (2 preceding siblings ...)
2023-05-11 7:04 ` Arnd Bergmann
@ 2023-05-11 7:57 ` Heiko Carstens
3 siblings, 0 replies; 8+ messages in thread
From: Heiko Carstens @ 2023-05-11 7:57 UTC (permalink / raw)
To: Nhat Pham
Cc: dalias, linux-ia64, linux-sh, linux-mips, James.Bottomley,
linux-mm, sparclinux, agordeev, linux-arch, linux-s390, ysato,
deller, linux, geert, mattst88, borntraeger, linux-alpha, gor,
kernel-team, richard.henderson, npiggin, linux-m68k, ink,
glaubitz, linux-arm-kernel, chris, monstr, tsbogend, linux-parisc,
jcmvbkbc, linux-api, linux-kernel, svens, hannes, akpm,
linuxppc-dev, davem
On Wed, May 10, 2023 at 12:58:06PM -0700, Nhat Pham wrote:
> cachestat is previously only wired in for x86 (and architectures using
> the generic unistd.h table):
>
> https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/
>
> This patch wires cachestat in for all the other architectures.
>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ---
...
> arch/s390/kernel/syscalls/syscall.tbl | 1 +
Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390)
^ permalink raw reply [flat|nested] 8+ messages in thread