From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: linuxppc-dev@ozlabs.org, benh@kernel.crashing.org, aik@ozlabs.ru,
dvaleev@suse.com
Subject: Re: [PATCH SLOF] disk-label: add support for booting from GPT FAT partition
Date: Thu, 18 Jun 2015 11:54:13 +0530 [thread overview]
Message-ID: <874mm5edpu.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150617122248.77211775@thh440s>
Thomas Huth <thuth@redhat.com> writes:
> On Thu, 11 Jun 2015 15:48:49 +0530
> Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> wrote:
>
>> + block-size * to seek-pos
>> + block gpt>part-entry-size l@-le to gpt-part-size
>> + block gpt>num-part-entry l@-le dup 0= IF FALSE EXIT THEN
>> + 1+ 1 ?DO
>> + seek-pos 0 seek drop
>> + block gpt-part-size read drop
>
> Can you be sure that gpt-part-size is only smaller than 4096 bytes
> here?
So the size is usually 128, so this should be fine.
https://en.wikipedia.org/wiki/GUID_Partition_Table
Section: GPT header format
"84 (0x54) 4 bytes Size of a single partition entry (usually 128)"
> If not, you might overflow the block array, don't you?
Regards
Nikunj
next prev parent reply other threads:[~2015-06-18 6:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 10:18 [PATCH SLOF] disk-label: add support for booting from GPT FAT partition Nikunj A Dadhania
2015-06-17 10:22 ` Thomas Huth
2015-06-17 11:59 ` Nikunj A Dadhania
2015-06-17 12:04 ` Nikunj A Dadhania
2015-06-19 16:27 ` Thomas Huth
2015-06-19 17:47 ` Nikunj A Dadhania
2015-06-18 6:24 ` Nikunj A Dadhania [this message]
2015-06-19 16:35 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mm5edpu.fsf@linux.vnet.ibm.com \
--to=nikunj@linux.vnet.ibm.com \
--cc=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=dvaleev@suse.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).