From: Michael Ellerman <mpe@ellerman.id.au>
To: Michal Suchanek <msuchanek@suse.de>, linuxppc-dev@lists.ozlabs.org
Cc: Michal Suchanek <msuchanek@suse.de>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Naveen N Rao <naveen@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Masahiro Yamada <masahiroy@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org,
"Nysal Jan K.A." <nysal@linux.ibm.com>
Subject: Re: [PATCH v2] powerpc/boot: Fix build with gcc 15
Date: Sat, 29 Mar 2025 20:11:08 +1100 [thread overview]
Message-ID: <875xjsjj6b.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20250314092528.15506-1-msuchanek@suse.de>
Michal Suchanek <msuchanek@suse.de> writes:
> Similar to x86 the ppc boot code does not build with GCC 15.
>
> Copy the fix from
> commit ee2ab467bddf ("x86/boot: Use '-std=gnu11' to fix build with GCC 15")
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> v2: Move the fix outside of ifdef to apply to all subarchitectures
> ---
> arch/powerpc/boot/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
> index 1ff6ad4f6cd2..210c60d3d4cc 100644
> --- a/arch/powerpc/boot/Makefile
> +++ b/arch/powerpc/boot/Makefile
> @@ -32,6 +32,8 @@ else
> BOOTAR := $(AR)
> endif
>
> +BOOTTARGETFLAGS += -std=gnu11
> +
BOOTTARGETFLAGS gets added to CFLAGS and AFLAGS.
I think -std=gnu11 should only be added to CFLAGS. In which case it'd be
better to add it directly to BOOTCFLAGS further down.
cheers
next prev parent reply other threads:[~2025-03-29 9:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 9:20 [PATCH] powerpc/boot: Fix build with gcc 15 Michal Suchanek
2025-03-08 10:09 ` Nysal Jan K.A.
2025-03-10 8:40 ` Michal Suchánek
2025-03-14 9:25 ` [PATCH v2] " Michal Suchanek
2025-03-29 9:11 ` Michael Ellerman [this message]
2025-03-31 10:57 ` [PATCH v3] " Michal Suchanek
2025-04-17 4:39 ` Venkat Rao Bagalkote
2025-05-05 12:14 ` Amit Machhiwal
2025-05-14 4:03 ` Madhavan Srinivasan
2025-04-17 6:07 ` [PATCH] " Mukesh Kumar Chaurasiya
2025-04-17 11:02 ` Michal Suchánek
2025-04-21 8:26 ` Mukesh Kumar Chaurasiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xjsjj6b.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=bhelgaas@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=masahiroy@kernel.org \
--cc=msuchanek@suse.de \
--cc=naveen@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=npiggin@gmail.com \
--cc=nysal@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).