* [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7
@ 2025-01-13 17:19 Andreas Schwab
2025-01-17 21:53 ` Rob Herring
2025-03-14 3:46 ` Madhavan Srinivasan
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Schwab @ 2025-01-13 17:19 UTC (permalink / raw)
To: linuxppc-dev; +Cc: robh, saravanak, linux-kernel, devicetree, Michael Ellerman
Similar to the PowerMac3,1, the PowerBook6,7 is missing the #size-cells
property on the i2s node.
Depends-on: 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling")
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
arch/powerpc/kernel/prom_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 8e776ba39497..24b1523eeea8 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -2898,11 +2898,11 @@ static void __init fixup_device_tree_pmac(void)
char type[8];
phandle node;
- // Some pmacs are missing #size-cells on escc nodes
+ // Some pmacs are missing #size-cells on escc or i2s nodes
for (node = 0; prom_next_node(&node); ) {
type[0] = '\0';
prom_getprop(node, "device_type", type, sizeof(type));
- if (prom_strcmp(type, "escc"))
+ if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s"))
continue;
if (prom_getproplen(node, "#size-cells") != PROM_ERROR)
--
2.48.0
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7
2025-01-13 17:19 [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7 Andreas Schwab
@ 2025-01-17 21:53 ` Rob Herring
2025-03-14 3:46 ` Madhavan Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2025-01-17 21:53 UTC (permalink / raw)
To: Andreas Schwab
Cc: linuxppc-dev, saravanak, linux-kernel, devicetree,
Michael Ellerman
On Mon, Jan 13, 2025 at 11:19 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> Similar to the PowerMac3,1, the PowerBook6,7 is missing the #size-cells
> property on the i2s node.
>
> Depends-on: 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling")
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
> arch/powerpc/kernel/prom_init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7
2025-01-13 17:19 [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7 Andreas Schwab
2025-01-17 21:53 ` Rob Herring
@ 2025-03-14 3:46 ` Madhavan Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: Madhavan Srinivasan @ 2025-03-14 3:46 UTC (permalink / raw)
To: linuxppc-dev, Andreas Schwab
Cc: robh, saravanak, linux-kernel, devicetree, Michael Ellerman
On Mon, 13 Jan 2025 18:19:09 +0100, Andreas Schwab wrote:
> Similar to the PowerMac3,1, the PowerBook6,7 is missing the #size-cells
> property on the i2s node.
>
>
Applied to powerpc/next.
[1/1] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7
https://git.kernel.org/powerpc/c/7e67ef889c9ab7246547db73d524459f47403a77
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-14 3:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-13 17:19 [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7 Andreas Schwab
2025-01-17 21:53 ` Rob Herring
2025-03-14 3:46 ` Madhavan Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).