From: Michael Ellerman <mpe@ellerman.id.au>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux@ew.tq-group.com
Subject: Re: [PATCH] powerpc/6xx: set High BAT Enable flag on G2 cores
Date: Fri, 22 Dec 2023 12:16:38 +1100 [thread overview]
Message-ID: <875y0rkpe1.fsf@mail.lhotse> (raw)
In-Reply-To: <20231221124538.159706-1-matthias.schiffer@ew.tq-group.com>
Matthias Schiffer <matthias.schiffer@ew.tq-group.com> writes:
> MMU_FTR_USE_HIGH_BATS is set for G2-based cores (G2_LE, e300cX), but the
> high BATs need to be enabled in HID2 to work. Add register definitions
> and introduce a G2 variant of __setup_cpu_603.
>
> This fixes boot on CPUs like the MPC5200B with STRICT_KERNEL_RWX enabled.
Nice find.
Minor nit on naming. The 32-bit code mostly uses the numeric names, eg.
603, 603e, 604 etc. Can we stick with that, rather than using "G2"?
Wikipedia says G2 == 603e. But looking at your patch you're not changing
all the 603e cores, so I guess it's not that clear cut?
If using "G2" makes the most sense then it would be nice to update
Documentation/arch/powerpc/cpu_families.rst to mention it (not asking
you to do it necessarily, more a note for us).
cheers
next prev parent reply other threads:[~2023-12-22 1:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 12:45 [PATCH] powerpc/6xx: set High BAT Enable flag on G2 cores Matthias Schiffer
2023-12-21 13:57 ` Christophe Leroy
2023-12-22 8:48 ` Matthias Schiffer
2023-12-22 18:41 ` Christophe Leroy
2024-01-19 13:41 ` Matthias Schiffer
2024-01-19 13:53 ` Christophe Leroy
2024-01-23 12:05 ` Matthias Schiffer
2023-12-22 1:16 ` Michael Ellerman [this message]
2023-12-22 8:34 ` Matthias Schiffer
2023-12-22 15:11 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y0rkpe1.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).