From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C650FC3F2D1 for ; Thu, 5 Mar 2020 06:10:08 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EC012073D for ; Thu, 5 Mar 2020 06:10:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="hksLamx9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EC012073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48Y0hs5YdNzDql2 for ; Thu, 5 Mar 2020 17:10:05 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48Y0g05rk6zDqkK for ; Thu, 5 Mar 2020 17:08:28 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=hksLamx9; dkim-atps=neutral Received: by ozlabs.org (Postfix) id 48Y0g03Pmsz9sQt; Thu, 5 Mar 2020 17:08:28 +1100 (AEDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 48Y0g02MHfz9sNg; Thu, 5 Mar 2020 17:08:28 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1583388508; bh=NxWK+ZJrvSNKWYtiMj0zrErsYhVkJSm14BmzCSHgBOo=; h=From:To:Subject:In-Reply-To:References:Date:From; b=hksLamx94PxlEKTHyNNj1Pnu6y6PowlKRQCw/JrRWCB0NUp2KaEB6lyDwiCWm7dL4 YfZJqhRHlp27/98Y5OzX/1OHaYkF6IZHqIu27bziUQkNN5LfZYzGYdUxg3Wq8UHetI osiOqCJiEqLuU9rk+FHpmhqHpfGabE9QQAIlZEXSBzqxxNm37K1Px03vzy//fOSCeq j2trJChuvZPKqQ6dwQIbPV2Lv34vOKJ+CQRIMMsiLoUk2GPm6Hb9H715GtSVusguo7 quwSUJHOjGVXtA+Lu9iRRuD8iShTankeJ5ewIGcKrLWej+mUS5+g24baZ2uMmzbUn2 1dZ5sQq/0CWCA== From: Michael Ellerman To: Andrew Donnellan , linuxppc-dev@ozlabs.org Subject: Re: [PATCH v2] powerpc/mm: Fix missing KUAP disable in flush_coherent_icache() In-Reply-To: References: <20200303235708.26004-1-mpe@ellerman.id.au> Date: Thu, 05 Mar 2020 17:08:25 +1100 Message-ID: <875zfjqqp2.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Andrew Donnellan writes: > On 4/3/20 10:57 am, Michael Ellerman wrote: >> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c >> index ef7b1119b2e2..36a8c7b105ce 100644 >> --- a/arch/powerpc/mm/mem.c >> +++ b/arch/powerpc/mm/mem.c >> @@ -373,7 +373,9 @@ static inline bool flush_coherent_icache(unsigned long addr) >> */ >> if (cpu_has_feature(CPU_FTR_COHERENT_ICACHE)) { >> mb(); /* sync */ >> + allow_read_from_user((void *)addr, L1_CACHE_BYTES); >> icbi((void *)addr); >> + prevent_read_from_user((void *)addr, L1_CACHE_BYTES); >> mb(); /* sync */ >> isync(); >> return true; >> > > (void *) should be (const void __user *) to avoid sparse warnings. > > snowpatch reports: https://patchwork.ozlabs.org/patch/1248671/ Thanks. cheers