From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
segher@kernel.crashing.org, npiggin@gmail.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] powerpc: permanently include 8xx registers in reg.h
Date: Thu, 29 Aug 2019 16:30:16 +1000 [thread overview]
Message-ID: <875zmgv5zb.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <e3de2a60198c1b648a5da19ba29938a1e365d1f3.1566931178.git.christophe.leroy@c-s.fr>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Most 8xx registers have specific names, so just include
> reg_8xx.h all the time in reg.h in order to have them defined
> even when CONFIG_PPC_8xx is not selected. This will avoid
> the need for #ifdefs in C code.
>
> Guard SPRN_ICTRL in an #ifdef CONFIG_PPC_8xx as this register
> has same name but different meaning and different spr number as
> another register in the mpc7450.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
> ---
> v2: no change
> ---
> arch/powerpc/include/asm/reg.h | 2 --
> arch/powerpc/include/asm/reg_8xx.h | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
This breaks the ppc64e build unfortunately, presumably due to it
changing the ordering of header inclusion.
In file included from ../arch/powerpc/include/asm/percpu.h:13,
from ../arch/powerpc/include/asm/mmu.h:137,
from ../arch/powerpc/include/asm/reg_8xx.h:8,
from ../arch/powerpc/include/asm/reg.h:28,
from ../arch/powerpc/include/asm/processor.h:9,
from ../include/linux/processor.h:6,
from ../arch/powerpc/include/asm/delay.h:6,
from ../include/linux/delay.h:26,
from ../lib/nmi_backtrace.c:17:
../arch/powerpc/include/asm/paca.h:147:23: error: field 'tcd' has incomplete type
struct tlb_core_data tcd;
^~~
cheers
prev parent reply other threads:[~2019-08-29 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 18:39 [PATCH v2 1/2] powerpc: permanently include 8xx registers in reg.h Christophe Leroy
2019-08-27 18:39 ` [PATCH v2 2/2] powerpc: cleanup hw_irq.h Christophe Leroy
2019-08-29 6:30 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zmgv5zb.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox