From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/traps: merge unrecoverable_exception() and nonrecoverable_exception()
Date: Tue, 25 Sep 2018 11:29:01 +1000 [thread overview]
Message-ID: <875zyu5pr6.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <f49e2e4ff1eacbad161eb6c1645cca7a281dcf3e.1537765881.git.christophe.leroy@c-s.fr>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> index 6ab66a88db14..4567eeb6524e 100644
> --- a/arch/powerpc/kernel/traps.c
> +++ b/arch/powerpc/kernel/traps.c
> @@ -2090,8 +2082,9 @@ void SPEFloatingPointRoundException(struct pt_regs *regs)
> */
> void unrecoverable_exception(struct pt_regs *regs)
> {
> - printk(KERN_EMERG "Unrecoverable exception %lx at %lx\n",
> - regs->trap, regs->nip);
> + pr_emerg("Unrecoverable exception %lx at %lx (msr=%lx)\n",
> + regs->trap, regs->nip, regs->msr);
> + debugger(regs);
> die("Unrecoverable exception", regs, SIGABRT);
die() already calls debugger() if the trap is != 0x100.
I don't think we want to call it twice?
cheers
next prev parent reply other threads:[~2018-09-25 1:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 5:35 [PATCH] powerpc/traps: merge unrecoverable_exception() and nonrecoverable_exception() Christophe Leroy
2018-09-25 1:29 ` Michael Ellerman [this message]
2018-09-25 4:43 ` Christophe LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zyu5pr6.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox