From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yqsf46BFwzDrbr for ; Mon, 4 Dec 2017 15:41:32 +1100 (AEDT) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vB44dkt7094725 for ; Sun, 3 Dec 2017 23:41:30 -0500 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0b-001b2d01.pphosted.com with ESMTP id 2emuju1dre-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sun, 03 Dec 2017 23:41:29 -0500 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 3 Dec 2017 21:41:29 -0700 From: Stewart Smith To: Shilpasri G Bhat , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com, akshay.adiga@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com Subject: Re: [PATCH] powerpc/powernv : Add support to enable sensor groups In-Reply-To: <06a771ec-fc79-0515-9166-f2a105eb33d0@linux.vnet.ibm.com> References: <1511760988-10377-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <87bmjmzla7.fsf@concordia.ellerman.id.au> <06a771ec-fc79-0515-9166-f2a105eb33d0@linux.vnet.ibm.com> Date: Mon, 04 Dec 2017 15:41:21 +1100 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87609nxfym.fsf@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Shilpasri G Bhat writes: > On 11/28/2017 05:07 PM, Michael Ellerman wrote: >> Shilpasri G Bhat writes: >> >>> Adds support to enable/disable a sensor group. This can be used to >>> select the sensor groups that needs to be copied to main memory by >>> OCC. Sensor groups like power, temperature, current, voltage, >>> frequency, utilization can be enabled/disabled at runtime. >>> >>> Signed-off-by: Shilpasri G Bhat >>> --- >>> The skiboot patch for the opal call is posted below: >>> https://lists.ozlabs.org/pipermail/skiboot/2017-November/009713.html >> >> Can you remind me why we're doing this with a completely bespoke sysfs >> API, rather than using some generic sensors API? >> > > Disabling/Enabling sensor groups is not supported in the current generic sensors > API. And also we dont export all type of sensors in HWMON as not all of them are > environment sensors (like performance). Are there barriers to adding such concepts to the generic sensors API? -- Stewart Smith OPAL Architect, IBM.