From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
paulus@samba.org, mpe@ellerman.id.au, akpm@linux-foundation.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/4] hugetlb: Change the function prototype to take vma_area_struct as arg
Date: Fri, 11 Nov 2016 07:08:50 +0530 [thread overview]
Message-ID: <8760nu23th.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1478806599.7430.139.camel@kernel.crashing.org>
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> On Thu, 2016-11-10 at 14:59 +0530, Aneesh Kumar K.V wrote:
>> This help us to find the hugetlb page size which we need ot use on some
>> archs like ppc64 for tlbflush. This also make the interface consistent
>> with other hugetlb functions
>
> What about my requested simpler approach ?
Still working on the changes.
>
> For normal (non-huge) pages, we already know the size.
>
> For huge pages, can't we encode in the top SW bits of the PTE the
> page size that we obtain from set_pte_at ?
>
> That would be a lot less churn and avoid touching all these archs...
> especially since the current DD1 workaround is horrible and I want
> the fix to be backported, so something simpler and contained in
> arch/powerpc feels more suitable.
>
My take as of now is even though the modification lines will be less, it
is going to be much more difficult to follow and backport. I will try to
do a patch to show the complexity and we can decide which approach is
simpler.
-aneesh
next prev parent reply other threads:[~2016-11-11 1:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 9:29 [PATCH 1/4] powerpc/mm: update ptep_set_access_flag to not do full mm tlb flush Aneesh Kumar K.V
2016-11-10 9:29 ` [PATCH 2/4] powerpc/mm: Rename hugetlb-radix.h to hugetlb.h Aneesh Kumar K.V
2016-11-10 9:29 ` [PATCH 3/4] hugetlb: Change the function prototype to take vma_area_struct as arg Aneesh Kumar K.V
2016-11-10 19:36 ` Benjamin Herrenschmidt
2016-11-11 1:38 ` Aneesh Kumar K.V [this message]
2016-11-10 9:29 ` [PATCH 4/4] powerpc/mm: update pte_update to not do full mm tlb flush Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760nu23th.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).