From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3sTldq5F03zDsFQ for ; Thu, 8 Sep 2016 00:07:11 +1000 (AEST) From: ebiederm@xmission.com (Eric W. Biederman) To: Thiago Jung Bauermann Cc: kexec@lists.infradead.org, linux-security-module@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Dave Young , Vivek Goyal , Baoquan He , Michael Ellerman , Stewart Smith , Mimi Zohar , Eric Richter , Andrew Morton , Balbir Singh References: <1472579105-26296-1-git-send-email-bauerman@linux.vnet.ibm.com> Date: Wed, 07 Sep 2016 08:51:24 -0500 In-Reply-To: <1472579105-26296-1-git-send-email-bauerman@linux.vnet.ibm.com> (Thiago Jung Bauermann's message of "Tue, 30 Aug 2016 14:45:00 -0300") Message-ID: <8760q7lswz.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Thiago Jung Bauermann writes: > Hello, > > The purpose of this new version of the series is to fix a small issue that > I found, which is that the kernel doesn't remove the memory reservation > for the hand-over buffer it received from the previous kernel in the > device tree it sets up for the next kernel. The result is that for each > successive kexec, a stale hand-over buffer is left behind, wasting memory. > > This is fixed by changes to kexec_free_handover_buffer and > setup_handover_buffer in patch 2. The other change is to fix checkpatch > warnings in the last patch. This is fundamentally broken. You do not increase the integrity of a system by dropping integrity checks. No. No. No. No. Nacked-by: "Eric W. Biederman" Eric