From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
benh@kernel.crashing.org, paulus@samba.org
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm/hash: Clear the invalid slot information correctly
Date: Sat, 20 Feb 2016 20:02:58 +0530 [thread overview]
Message-ID: <8760xje9k5.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455878263.6506.4.camel@ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> writes:
> On Fri, 2016-02-19 at 11:23 +0530, Anshuman Khandual wrote:
>> On 02/18/2016 10:14 PM, Aneesh Kumar K.V wrote:
>> > We can get a hash pte fault with 4k base page size and find the pte
>> > already inserted with 64K base page size. In that case we need to clear
> ...
>>
>> > diff --git a/arch/powerpc/mm/hash64_4k.c b/arch/powerpc/mm/hash64_4k.c
>> > index e7c04542ba62..e3e76b929f33 100644
>> > --- a/arch/powerpc/mm/hash64_4k.c
>> > +++ b/arch/powerpc/mm/hash64_4k.c
>> > @@ -106,7 +106,7 @@ repeat:
>> > }
>> > }
>> > /*
>> > - * Hypervisor failure. Restore old pmd and return -1
>> > + * Hypervisor failure. Restore old pte and return -1
>>
>> This change is not relevant here. Should be a separate patch.
>
> Yeah.
>
> If it was -rc1 then I would probably let it go, but this will land in rc6 so
> the fixes need to be tight.
>
You want me to do an upate with those changes dropped ?.
-aneesh
next prev parent reply other threads:[~2016-02-20 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 16:44 [PATCH] powerpc/mm/hash: Clear the invalid slot information correctly Aneesh Kumar K.V
2016-02-19 5:53 ` Anshuman Khandual
2016-02-19 10:37 ` Michael Ellerman
2016-02-20 14:32 ` Aneesh Kumar K.V [this message]
2016-02-20 15:13 ` Aneesh Kumar K.V
2016-02-19 11:30 ` Balbir Singh
2016-02-20 14:34 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760xje9k5.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).