From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp09.au.ibm.com (e23smtp09.au.ibm.com [202.81.31.142]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 5990F1A0279 for ; Tue, 13 Oct 2015 16:24:06 +1100 (AEDT) Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Oct 2015 15:24:04 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 7BC823578055 for ; Tue, 13 Oct 2015 16:24:02 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t9D5Ngb065273948 for ; Tue, 13 Oct 2015 16:23:50 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t9D5NTks029589 for ; Tue, 13 Oct 2015 16:23:29 +1100 From: "Aneesh Kumar K.V" To: Michael Ellerman Cc: benh@kernel.crashing.org, paulus@samba.org, Scott Wood , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3 10/31] powerpc/mm: Don't use pmd_val, pud_val and pgd_val as lvalue In-Reply-To: <1444713006.29347.2.camel@ellerman.id.au> References: <1444675215-19484-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1444675215-19484-11-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1444713006.29347.2.camel@ellerman.id.au> Date: Tue, 13 Oct 2015 10:53:09 +0530 Message-ID: <87612btk8y.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Michael Ellerman writes: > On Tue, 2015-10-13 at 00:09 +0530, Aneesh Kumar K.V wrote: >> We convert them static inline function here as we did with pte_val in >> the previous patch > > This breaks ppc40x_defconfig & 40x/ep405_defconfig with: > > arch/powerpc/mm/40x_mmu.c: In function 'mmu_mapin_ram': > arch/powerpc/mm/40x_mmu.c:113:20: error: lvalue required as left operand of assignment > arch/powerpc/mm/40x_mmu.c:114:20: error: lvalue required as left operand of assignment > arch/powerpc/mm/40x_mmu.c:115:20: error: lvalue required as left operand of assignment > arch/powerpc/mm/40x_mmu.c:116:20: error: lvalue required as left operand of assignment > arch/powerpc/mm/40x_mmu.c:128:18: error: lvalue required as left operand of assignment > > Which is mainly: > > pmd_val(*pmdp++) = val; > > > The obvious patch to use pmd_set() doesn't work, I think because there's no > pmd_set() defined for 32-bit nohash? > How about diff --git a/arch/powerpc/mm/40x_mmu.c b/arch/powerpc/mm/40x_mmu.c index 5810967511d4..31a5d42df8c9 100644 --- a/arch/powerpc/mm/40x_mmu.c +++ b/arch/powerpc/mm/40x_mmu.c @@ -110,10 +110,10 @@ unsigned long __init mmu_mapin_ram(unsigned long top) unsigned long val = p | _PMD_SIZE_16M | _PAGE_EXEC | _PAGE_HWWRITE; pmdp = pmd_offset(pud_offset(pgd_offset_k(v), v), v); - pmd_val(*pmdp++) = val; - pmd_val(*pmdp++) = val; - pmd_val(*pmdp++) = val; - pmd_val(*pmdp++) = val; + *pmdp++ = __pmd(val); + *pmdp++ = __pmd(val); + *pmdp++ = __pmd(val); + *pmdp++ = __pmd(val); v += LARGE_PAGE_SIZE_16M; p += LARGE_PAGE_SIZE_16M; @@ -125,7 +125,7 @@ unsigned long __init mmu_mapin_ram(unsigned long top) unsigned long val = p | _PMD_SIZE_4M | _PAGE_EXEC | _PAGE_HWWRITE; pmdp = pmd_offset(pud_offset(pgd_offset_k(v), v), v); - pmd_val(*pmdp) = val; + *pmdp = __pmd(val); v += LARGE_PAGE_SIZE_4M; p += LARGE_PAGE_SIZE_4M;