LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vaibhav Jain <vaibhav@linux.ibm.com>
To: Gautam Menghani <gautam@linux.ibm.com>
Cc: Amit Machhiwal <amachhiw@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Harsh Prateek Bora <harshpb@linux.ibm.com>,
	Ritesh Harjani <ritesh.list@gmail.com>,
	Anushree Mathur <anushree.mathur@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	kvm@vger.kernel.org, stable@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Validate arch_compat against host compatibility mode
Date: Mon, 08 Jun 2026 19:49:25 +0530	[thread overview]
Message-ID: <877bo9m7wy.fsf@vajain21.in.ibm.com> (raw)
In-Reply-To: <aiaAPQmWG7JXGoGn@Gautams-MacBook-Pro.local>

Gautam Menghani <gautam@linux.ibm.com> writes:

> On Fri, Jun 05, 2026 at 12:55:50PM +0530, Vaibhav Jain wrote:
>> Hi Gautam,
>> 
>> Thanks for testing this patch. Few questions:
>> Gautam Menghani <gautam@linux.ibm.com> writes:
>> 
>> > On Wed, Jun 03, 2026 at 07:45:39PM +0530, Amit Machhiwal wrote:
>> >> On IBM POWER systems, newer processor generations can operate in
>> >> compatibility modes corresponding to earlier generations. This becomes
>> >> relevant for nested virtualization, where nested KVM guests may need to
>> >> run with a specific processor compatibility level.
>> >> 
>> <snip>
>> >
>> > I booted a KVM guest on LPAR with this patch in the following scenarios:
>> <snip>
>> 
>> > 3. P11 guest on P11 host booted in P10 compat mode: No error observed
>> This should have resulted in an error since booting a P11 guest on P10
>> compat mode host is not allowed with/without this patch. Can you please
>> check your test env and share the boot results.
>
> - lscpu output (host P11 LPAR booted in p10 compat mode)
> # lscpu                                                                                                                                                   03:35:13 [3/3]
> Architecture:                ppc64le
>   Byte Order:                Little Endian
> CPU(s):                      960
>   On-line CPU(s) list:       0-959
> Model name:                  POWER10 (architected), altivec supported
>   Model:                     2.0 (pvr 0082 0200)
>   Thread(s) per core:        8
>   Core(s) per socket:        15
>   Socket(s):                 8
>   Physical sockets:          4
>   Physical chips:            2
>   Physical cores/chip:       16
>
>
> - lscpu output from guest
> # lscpu
> Architecture:             ppc64le
>   Byte Order:             Little Endian
> CPU(s):                   4
>   On-line CPU(s) list:    0-3
> Model name:               Power11 (raw), altivec supported
>   Model:                  2.0 (pvr 0082 0200)
>   Thread(s) per core:     1
>   Core(s) per socket:     4
>   Socket(s):              1
>
Argh, this doesnt look right. The kernel patch should have prevented the
P11 compat guest boot on P10 compat host. Looks like you havent used the
corrosponding Qemu patch [1] that could have prevented this from
happening.

Had a off mailing list discussion with Amit on how to address this issue
and he will be sending a new version of the patch to address this issue.


[1] https://lore.kernel.org/all/20260502140021.69712-2-amachhiw@linux.ibm.com/

>
>
> - QEMU command line
> /usr/bin/qemu-system-ppc64 -device virtio-blk-pci,drive=drive0,id=virtblk0 \
>     -drive file=/home/gautam/images/fc41.qcow2,format=qcow2,if=none,id=drive0 \
>     -m 100G -smp 4 -cpu host -nographic -machine pseries,ic-mode=xics -accel kvm
>
>
> Thanks,
> Gautam
>

-- 
Cheers
~ Vaibhav


  parent reply	other threads:[~2026-06-08 14:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 14:15 [PATCH] KVM: PPC: Book3S HV: Validate arch_compat against host compatibility mode Amit Machhiwal
2026-06-03 15:11 ` Ritesh Harjani
2026-06-03 17:57 ` Mukesh Kumar Chaurasiya
2026-06-04 14:20 ` Gautam Menghani
2026-06-05  7:25   ` Vaibhav Jain
2026-06-08  8:41     ` Gautam Menghani
2026-06-08 10:12       ` Amit Machhiwal
2026-06-08 14:19       ` Vaibhav Jain [this message]
2026-06-05  7:30 ` Vaibhav Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877bo9m7wy.fsf@vajain21.in.ibm.com \
    --to=vaibhav@linux.ibm.com \
    --cc=amachhiw@linux.ibm.com \
    --cc=anushree.mathur@linux.ibm.com \
    --cc=chleroy@kernel.org \
    --cc=gautam@linux.ibm.com \
    --cc=harshpb@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox